You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Apache9 (via GitHub)" <gi...@apache.org> on 2026/06/12 04:08:01 UTC

[PR] HBASE-30223 TestRegionMover2.testWithMergedRegions may merge disjoint… [hbase]

Apache9 opened a new pull request, #8342:
URL: https://github.com/apache/hbase/pull/8342

   … regions and cause tests to fail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30223 TestRegionMover2.testWithMergedRegions may merge disjoint… [hbase]

Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #8342:
URL: https://github.com/apache/hbase/pull/8342#issuecomment-4689420097

   https://github.com/apache/hbase/pull/8341 encountered the same error, thanks for the fixing!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30223 TestRegionMover2.testWithMergedRegions may merge disjoint… [hbase]

Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #8342:
URL: https://github.com/apache/hbase/pull/8342#discussion_r3402035097


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover2.java:
##########
@@ -112,23 +119,36 @@ public void testWithMergedRegions() throws Exception {
     table.put(puts);
     admin.flush(tableName);
     HRegionServer regionServer = cluster.getRegionServer(0);
+    RegionInfo regionA = regionServer.getRegions(tableName).get(0).getRegionInfo();

Review Comment:
   If `regionA` is the last region of the table, in which case its endKey is empty, and regionB would then match the first region so we'd end up merging two disjoint regions again? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30223 TestRegionMover2.testWithMergedRegions may merge disjoint… [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 merged PR #8342:
URL: https://github.com/apache/hbase/pull/8342


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30223 TestRegionMover2.testWithMergedRegions may merge disjoint… [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #8342:
URL: https://github.com/apache/hbase/pull/8342#discussion_r3402675877


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover2.java:
##########
@@ -112,23 +119,36 @@ public void testWithMergedRegions() throws Exception {
     table.put(puts);
     admin.flush(tableName);
     HRegionServer regionServer = cluster.getRegionServer(0);
+    RegionInfo regionA = regionServer.getRegions(tableName).get(0).getRegionInfo();

Review Comment:
   Not likely but OK, let me make it more robust, there is also possible that the region server does not contain any regions of this table, let me deal with it too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30223 TestRegionMover2.testWithMergedRegions may merge disjoint… [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #8342:
URL: https://github.com/apache/hbase/pull/8342#issuecomment-4703736917

   The failed UTs are not touched and not related.
   
   Let me merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org