[jira] [Commented] (KYLIN-2858) add retry strategy in cache sync

["Shaofeng SHI (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157983#comment-16157983 ] 

Shaofeng SHI commented on KYLIN-2858:
-------------------------------------

Hi chao, 

I checked the pull request, two comments:

1) suggest to make the retry time (now it is hard coded as 3) as configurable as other kylin configurations;
2) the pull request included the patch file, that should be avoided. Only the patch file is okay, you can attach it in this JIRA.
3) if possible, add a unit test for this mechanism

Could you please make a new patch with "git format-patch" when fixed the issue? We will merge it. Thanks for your contribution!

> add retry strategy in cache sync 
> ---------------------------------
>
>                 Key: KYLIN-2858
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2858
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metadata
>    Affects Versions: v2.0.0, v2.1.0
>            Reporter: chaoli
>            Assignee: chaoli
>
> since there may be an situation that when sync request call a node that is down temporary and is restarting, sync cache may fail. So I add a retry strategy to avoid that situation



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)