You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/13 22:12:47 UTC

[GitHub] [incubator-seatunnel] mans2singh opened a new pull request #1481: [Refactor][flink-connector][elastic] - Refactored code to extract constants from config literals

mans2singh opened a new pull request #1481:
URL: https://github.com/apache/incubator-seatunnel/pull/1481


   ## Purpose of this pull request
   
   Refactored code to extract constants from embedded configuration literals for readability, reusability, and maintainability.
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] mans2singh commented on pull request #1481: [Refactor][flink-connector][elastic] - Refactored code to extract constants from config literals

Posted by GitBox <gi...@apache.org>.

mans2singh commented on pull request #1481:
URL: https://github.com/apache/incubator-seatunnel/pull/1481#issuecomment-1066659756


   Thanks @CalvinKirs.  Mans


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1481: [Refactor][flink-connector][elastic] - Refactored code to extract constants from config literals

Posted by GitBox <gi...@apache.org>.

CalvinKirs merged pull request #1481:
URL: https://github.com/apache/incubator-seatunnel/pull/1481


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org