You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Yunkai Zhang (JIRA)" <ji...@apache.org> on 2013/08/27 14:29:52 UTC

[jira] [Updated] (TS-2162) Auto-created collation LogObject would be misused by access log

     [ https://issues.apache.org/jira/browse/TS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yunkai Zhang updated TS-2162:
-----------------------------

    Description: 
When collation host receives LogBuffer data from network, it'll create LogObject according the data's format.

Since the LogFilter of these auto-created LogObjects are empty,  they will be misused by access log generated by collation host itself -- toss_this_entry() will always return false when m_does_conjunction is set.

I have a simple solution to fix this issue: make toss_this_entry() returns true when filter list is empty.

==NOTE==
After apply this solution, user should configure at least one LogFilter for each LogObject in logs_xml.config, otherwise the LogObject will be tossed always. Luckily, that is what most users do. I will update the comment of logs_xml.config.default at the same time to reflect this minor change.

  was:
When collation host receives LogBuffer data from network, it'll create LogObject according the format of LogBuffer data.

Since the log filter of these auto-created LogObjects are empty,  they will be misused by access log in collation host -- m_filter_list.toss_this_entry() will always return false when m_does_conjunction is set.

I have a simple solution to fix this issue: make toss_this_entry() returns true when filter list is empty.

==NOTE==
After apply this solution, user should configure at least one filter for each log object in logs_xml.config, otherwise the log object will be tossed always. Luckily, that what most users do. I will update the comment of logs_xml.config.default to reflect this minor change.

    
> Auto-created collation LogObject would be misused by access log
> ---------------------------------------------------------------
>
>                 Key: TS-2162
>                 URL: https://issues.apache.org/jira/browse/TS-2162
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>            Reporter: Yunkai Zhang
>
> When collation host receives LogBuffer data from network, it'll create LogObject according the data's format.
> Since the LogFilter of these auto-created LogObjects are empty,  they will be misused by access log generated by collation host itself -- toss_this_entry() will always return false when m_does_conjunction is set.
> I have a simple solution to fix this issue: make toss_this_entry() returns true when filter list is empty.
> ==NOTE==
> After apply this solution, user should configure at least one LogFilter for each LogObject in logs_xml.config, otherwise the LogObject will be tossed always. Luckily, that is what most users do. I will update the comment of logs_xml.config.default at the same time to reflect this minor change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira