[GitHub] rabbah opened a new pull request #4161: Revert "Proposing Lean OpenWhisk (#3886)"

[GitBox <gi...@apache.org>]

rabbah opened a new pull request #4161: Revert "Proposing Lean OpenWhisk (#3886)"
URL: https://github.com/apache/incubator-openwhisk/pull/4161
 
 
   This reverts commit d4a190c62f0aa1cd0bbecc62ad6b9885c70e9f6b.
   The reason I'm reverting the commit is because while I can do a local path to mirror some of the changes in the main (fat?) loadbalancer, there is already a fair bit of divergence in the two load balancers because the lean version clones and owns the code and so it's prone to such slippage.
   
   There is a cleaner organization which allows a common LB class which implements much of the logic that is shared between the two implementations. I started to do this on this branch https://github.com/apache/incubator-openwhisk/compare/master...rabbah:patch?expand=1 but it's clear it will take me a bit more time and we shouldn't break all the repos in the meantime.
   
   I further suggest in the refactoring that the lean LB actually implements identity actors for the invoker pool health and feeds so that there's less reason to diverge or special case some of the code. It's best to have one version of this code because it's functionally critical.
   
   @kpavel Sorry that I didn't get to review the code again more recently before it was merged, but I'm happy to help re-introduce this contribution with an improved organization as suggested here if you're agreeable.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services