You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/22 03:11:31 UTC

[GitHub] [spark] beliefer opened a new pull request #24671: [MINOR][DOCS]Improve docs about overhead.

beliefer opened a new pull request #24671: [MINOR][DOCS]Improve docs about overhead.
URL: https://github.com/apache/spark/pull/24671
 
 
   ## What changes were proposed in this pull request?
   
   I found the docs of `spark.driver.memoryOverhead` and `spark.executor.memoryOverhead` exists a little ambiguity.
   For example, the origin docs of `spark.driver.memoryOverhead` start with `The amount of off-heap memory to be allocated per driver in cluster mode`.
   But `MemoryManager` also managed a memory area named off-heap used to allocate memory in tungsten mode.
   So I think the description of `spark.driver.memoryOverhead` always make confused.
   
   `spark.executor.memoryOverhead` has the same confused with `spark.driver.memoryOverhead`.
   
   ## How was this patch tested?
   
   Exists UT.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org