You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Mark Brouwer <ma...@cheiron.org> on 2007/12/23 20:16:19 UTC
VOTING ISSUE with apache-river-2.1.1-incubating
Lately I was too entangled in trying to verify whether Frank is really
who he says he is and therefore I haven't tested the distributions other
than building from SVN.
Before voting I tried to build from the source and I can't due to:
BUILD FAILED
D:\tmp\apache-river-2.1.1\source\build_common.xml:877: Warning: Could
not find file D:\tmp\apache-river-2.1.1\source\NOTICE to copy.
I think we shouldn't release a source distribution that doesn't actually
build. But before voting I would like to know whether we can fix this
issue after we approved the release and before presenting a distribution
to Incubator. I hope so because I don't want to spoil the party.
--
Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
In doc/release-notes/outrigger.html, the wording implies that
logstore is still included.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
In doc/release-notes/index.html, the section on "Persistent Outrigger
JAR files" lists outrigger-logstore.jar and
prebuilt-outrigger-logstore.jar, neither of which now exist,
and omits outrigger-snaplogstore.jar, which does exist.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Mark Brouwer <ma...@cheiron.org>.
Frank Barnaby wrote:
> It seems like a JIRA issue should be created for the above
> items, but I don't think the release should be modified and/or
> delayed to address this issue.
Agreed, as said something for the future.
--
Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Monday 31 December 2007 18:31, Jukka Zitting wrote:
> Though I wouldn't consider this a blocker for
> 2.1.1-incubating, i.e. no need to roll a new release candidate.
I agree, hence the "for future" notes...
Cheers
--
Niclas Hedhman, Software Developer
I live here; http://tinyurl.com/2qq9er
I work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Dec 31, 2007 12:01 PM, Niclas Hedhman <ni...@hedhman.org> wrote:
> I think a short "licensed to ASF under Apache License v2.0" would be better.
I think we can do that. Though I wouldn't consider this a blocker for
2.1.1-incubating, i.e. no need to roll a new release candidate.
> Ok, so each and *all* contributors to the ServiceUI project have either;
>
> a) Made a copyright assign to Bill or Artima, which in turn has a Software
> Grant to ASF, OR
> b) Signed off to change the license from SCSL to ALv2 prior to coming
> to ASF, OR
> c) Provided a Software Grant, for their contribution, to the ASF.
AFAIK the ServiceUI API and code was mostly, if not completely,
written by Bill Venners based on input from various people (see
http://www.artima.com/jini/serviceui/acknowledgments.html). At least I
recall checking that only Bill was mentioned as the @author of the
class files when the contribution was included (see RIVER-10).
I guess Bill can clarify the contribution history of ServiceUI.
> Everyone, sorry for being a pain in the butt, but this is what ASF is all
> about when it comes its legal respect among our downstream users.
No problem, your input is much appreciated! :-)
BR,
Jukka Zitting
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Monday 31 December 2007 17:13, Jukka Zitting wrote:
> Hi,
>
> On Dec 31, 2007 6:33 AM, Niclas Hedhman <ni...@hedhman.org> wrote:
> > This release would get my vote, subject to the RAT report which I have
> > not run yet. The Incubator PMC is eternally grateful if the RAT report is
> > published as well.
>
> Available at
> http://people.apache.org/~jukka/river/2.1.1/apache-river-2.1.1-incubating.r
>at
Excellent...
> > * The Notice mentions that the release contains Copyrighted material
> > from Sun Microsystems. That is Ok, but it should also mention that Sun
> > has licensed this to ASF under ALv2.
>
> Do we need to do that in the NOTICE file? I wouldn't mind doing that,
> but should the NOTICE file carry the licensing histories as well as
> copyright notices? The fact that the code is ALv2 licensed is already
> stated in LICENSE and we have the paper trail for the contribution.
I think a short "licensed to ASF under Apache License v2.0" would be better.
> For example, the example NOTICE file at
> http://www.apache.org/licenses/example-NOTICE.txt doesn't contain
> licensing histories.
>
> > * The Notice mentions the Service UI project, developed by several
> > individuals, but doesn't mention any licensing. If the ServiceUI was
> > ALv2 from the beginning, then mention that. If it was something else, I
> > think that could possibly be an encumbered codebase, depending on
> > circumstances. I suggest that the Mentor(s) list this for investigation,
> > and clarify the result both in the incubating status file as well as in
> > the NOTICE.
>
> See above. We have a software grant for the ServiceUI contribution
> which makes it distributable under ALv2. Of course we could better
> document the licensing history (previously under Sun Community Source
> License), but I'm not sure it's necessary or even relevant.
Ok, so each and *all* contributors to the ServiceUI project have either;
a) Made a copyright assign to Bill or Artima, which in turn has a Software
Grant to ASF, OR
b) Signed off to change the license from SCSL to ALv2 prior to coming
to ASF, OR
c) Provided a Software Grant, for their contribution, to the ASF.
(Perhaps some other scenario is satisfactory as well, I just can't think of
any.)
I still think a similar text as above is suitable to simplify for downstream
users.
Everyone, sorry for being a pain in the butt, but this is what ASF is all
about when it comes its legal respect among our downstream users.
Cheers
--
Niclas Hedhman, Software Developer
I live here; http://tinyurl.com/2qq9er
I work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Jan 5, 2008 12:53 PM, Jim Hurley <ji...@mac.com> wrote:
> Yep - we expected there would be some growing pain in learning
> the ASF ways of getting a release out. It was actually one one of the
> reasons we first though of putting out this release (AR1) without a lot
> of functionality changes.
sounds like a good plan
the first release is the first chance that the IPMC gets to review the
codebase. this often involves tidying up and understanding provenance,
dependencies and other legal-related issues.
the IPMC is also interested in helping to improve the quality of
releases so there's quite a lot of pushing and proding. apache has
built up quite a wealth of experience over the years but there's also
a lot we can learn from existing projects. expect any practices which
are unfamiliar to us to be questioned. i recommend you to defend those
which make sense and discard those which don't.
BTW we're working on the release documentation ATM over on general.
it's a collegiate effort, trying to write up opinions about best
practice. all welcome.
- robert
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <ji...@mac.com>.
Yep - we expected there would be some growing pain in learning
the ASF ways of getting a release out. It was actually one one of the
reasons we first though of putting out this release (AR1) without a lot
of functionality changes.
Thanks again for all the insights.
Hoping others have a chance to look at the candidate Frank has posted
to see if there's anything (obviously) wrong.
-Jim
On Jan 4, 2008, at 11:43 PM, Niclas Hedhman wrote:
> On Saturday 05 January 2008 10:01, Jim Hurley wrote:
>> I don't want to start a vote and then have to restart again
>
> This is typical "incubator pain" that just about every project has
> during
> first and perhaps second release. Once that is settled, releases
> becomes
> a "technical only" affair (which we, the Incubator PMC don't
> interfere with).
>
> Cheers
> --
> Niclas Hedhman, Software Developer
>
> I live here; http://tinyurl.com/2qq9er
> I work here; http://tinyurl.com/2ymelc
> I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Saturday 05 January 2008 10:01, Jim Hurley wrote:
> I don't want to start a vote and then have to restart again
This is typical "incubator pain" that just about every project has during
first and perhaps second release. Once that is settled, releases becomes
a "technical only" affair (which we, the Incubator PMC don't interfere with).
Cheers
--
Niclas Hedhman, Software Developer
I live here; http://tinyurl.com/2qq9er
I work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
Good idea. I was tempted to change to a build-numbered sub directory,
and your suggestion is the nudge that I needed. I'll make the move as
soon as the vote is initiated.
Frank
On Jan 4, 2008, at 22:24, Craig L Russell wrote:
> When you do publish this for a vote, it would be good to put it into
> a directory that contains something like rc1. For example,
>
> http://people.apache.org/~fbarnaby/river/2.1.1/rc1
>
> Then in the completely unlikely event that you have to change
> something and call another vote, you can bump the number to rc2 and
> that will make it clear to voters that something has changed.
>
> Craig
>
> On Jan 4, 2008, at 6:01 PM, Jim Hurley wrote:
>
>> Thanks Frank.
>>
>> I don't want to start a vote and then have to restart again -- so I
>> plan
>> on pausing for a day or so for folks to take a look and make sure
>> they
>> don't see anything obvious that needs to be changed. If there are no
>> issues/discussions brought up on list, I'll restart a vote on
>> Sunday or
>> Monday.
>>
>> thanks -Jim
>>
>>
>>
>> On Jan 4, 2008, at 6:47 PM, Frank Barnaby wrote:
>>> I've uploaded a new release candidate to my people area:
>>>
>>> http://people.apache.org/~fbarnaby/river/2.1.1
>>>
>>> Here's what I've changed:
>>>
>>> - Removed references in info-index.html related to
>>> former (now obsolete) installation process.
>>> - Removed top-level docs from source distribution.
>>> - Fixed issues in release notes related to outrigger
>>> logstore and snaplogstore.
>>> - Fixed a typo in outrigger's package.html .
>>> - Added note to top-level build.xml referring users
>>> to doc/build.html for build instructions.
>>>
>>> I've also uploaded the Rat output.
>>>
>>>
>>> Frank
>>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Craig L Russell <Cr...@Sun.COM>.
When you do publish this for a vote, it would be good to put it into
a directory that contains something like rc1. For example,
http://people.apache.org/~fbarnaby/river/2.1.1/rc1
Then in the completely unlikely event that you have to change
something and call another vote, you can bump the number to rc2 and
that will make it clear to voters that something has changed.
Craig
On Jan 4, 2008, at 6:01 PM, Jim Hurley wrote:
> Thanks Frank.
>
> I don't want to start a vote and then have to restart again -- so I
> plan
> on pausing for a day or so for folks to take a look and make sure they
> don't see anything obvious that needs to be changed. If there are no
> issues/discussions brought up on list, I'll restart a vote on
> Sunday or
> Monday.
>
> thanks -Jim
>
>
>
> On Jan 4, 2008, at 6:47 PM, Frank Barnaby wrote:
>> I've uploaded a new release candidate to my people area:
>>
>> http://people.apache.org/~fbarnaby/river/2.1.1
>>
>> Here's what I've changed:
>>
>> - Removed references in info-index.html related to
>> former (now obsolete) installation process.
>> - Removed top-level docs from source distribution.
>> - Fixed issues in release notes related to outrigger
>> logstore and snaplogstore.
>> - Fixed a typo in outrigger's package.html .
>> - Added note to top-level build.xml referring users
>> to doc/build.html for build instructions.
>>
>> I've also uploaded the Rat output.
>>
>>
>> Frank
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <ji...@mac.com>.
Thanks Frank.
I don't want to start a vote and then have to restart again -- so I plan
on pausing for a day or so for folks to take a look and make sure they
don't see anything obvious that needs to be changed. If there are no
issues/discussions brought up on list, I'll restart a vote on Sunday or
Monday.
thanks -Jim
On Jan 4, 2008, at 6:47 PM, Frank Barnaby wrote:
> I've uploaded a new release candidate to my people area:
>
> http://people.apache.org/~fbarnaby/river/2.1.1
>
> Here's what I've changed:
>
> - Removed references in info-index.html related to
> former (now obsolete) installation process.
> - Removed top-level docs from source distribution.
> - Fixed issues in release notes related to outrigger
> logstore and snaplogstore.
> - Fixed a typo in outrigger's package.html .
> - Added note to top-level build.xml referring users
> to doc/build.html for build instructions.
>
> I've also uploaded the Rat output.
>
>
> Frank
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Jan 5, 2008 1:47 AM, Frank Barnaby <Fr...@sun.com> wrote:
> I've uploaded a new release candidate to my people area:
Do you want to start a release vote on it, or is this just for review?
PS. It gets confusing to have multiple subsequent 2.1.1-incubating
packages with identical version numbers. How about incrementing the
patch number or including a unique build number for each release
candidate?
BR,
Jukka Zitting
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Mark Brouwer <ma...@cheiron.org>.
Bob Scheifler wrote:
> Frank Barnaby wrote:
>> I've uploaded a new release candidate to my people area:
>>
>> http://people.apache.org/~fbarnaby/river/2.1.1
>
> Looks good to me.
Same here,
--
Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
Frank Barnaby wrote:
> I've uploaded a new release candidate to my people area:
>
> http://people.apache.org/~fbarnaby/river/2.1.1
Looks good to me.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
I've uploaded a new release candidate to my people area:
http://people.apache.org/~fbarnaby/river/2.1.1
Here's what I've changed:
- Removed references in info-index.html related to
former (now obsolete) installation process.
- Removed top-level docs from source distribution.
- Fixed issues in release notes related to outrigger
logstore and snaplogstore.
- Fixed a typo in outrigger's package.html .
- Added note to top-level build.xml referring users
to doc/build.html for build instructions.
I've also uploaded the Rat output.
Frank
On Jan 4, 2008, at 07:50, Jim Hurley wrote:
> Thanks very much for the quick response and guidance.
>
> -Jim
>
> On Jan 3, 2008, at 11:16 PM, Jukka Zitting wrote:
>> Hi,
>>
>> On Jan 4, 2008 5:45 AM, Jim Hurley <ji...@mac.com> wrote:
>>> Any words of advice from those more familiar with Apache incubator
>>> releases? Is this (including "incubating" in the directory name,
>>> basically matching the download name), common practice?
>>
>> It's a common practice to have the name of the packaged directory
>> match the name of the package, i.e.
>> apache-river-2.1.1-incubating-src.zip to apache-river-2.1.1-
>> incubating
>> (or even apache-river-2.1.1-incubating-src).
>>
>>> Or an ASF requirement?
>>
>> No.
>>
>>> I understand (and agree) with Niclas' point - but honestly hoping we
>>> can get AR1 out and move on (to AR2) without many other changes.
>>> In other words, can we put this off to AR2?
>>
>> Yes.
>>
>> BR,
>>
>> Jukka Zitting
>
> ------------------------
>
> On Jan 4, 2008, at 2:58 AM, Niclas Hedhman wrote:
>> On Friday 04 January 2008 11:45, Jim Hurley wrote:
>>> I understand (and agree) with Niclas' point - but honestly hoping we
>>> can get
>>> AR1 out and move on (to AR2) without many other changes. In other
>>> words,
>>> can we put this off to AR2?
>>
>> As I pointed out originally, it is something that doesn't need to
>> hold up the
>> current release, but something I would like to see in the future to
>> receive
>> my +1 vote.
>>
>> Cheers
>> --
>> Niclas Hedhman, Software Developer
>>
>> I live here; http://tinyurl.com/2qq9er
>> I work here; http://tinyurl.com/2ymelc
>> I relax here; http://tinyurl.com/2cgsug
>
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <ji...@mac.com>.
Thanks very much for the quick response and guidance.
-Jim
On Jan 3, 2008, at 11:16 PM, Jukka Zitting wrote:
> Hi,
>
> On Jan 4, 2008 5:45 AM, Jim Hurley <ji...@mac.com> wrote:
>> Any words of advice from those more familiar with Apache incubator
>> releases? Is this (including "incubating" in the directory name,
>> basically matching the download name), common practice?
>
> It's a common practice to have the name of the packaged directory
> match the name of the package, i.e.
> apache-river-2.1.1-incubating-src.zip to apache-river-2.1.1-incubating
> (or even apache-river-2.1.1-incubating-src).
>
>> Or an ASF requirement?
>
> No.
>
>> I understand (and agree) with Niclas' point - but honestly hoping we
>> can get AR1 out and move on (to AR2) without many other changes.
>> In other words, can we put this off to AR2?
>
> Yes.
>
> BR,
>
> Jukka Zitting
------------------------
On Jan 4, 2008, at 2:58 AM, Niclas Hedhman wrote:
> On Friday 04 January 2008 11:45, Jim Hurley wrote:
>> I understand (and agree) with Niclas' point - but honestly hoping we
>> can get
>> AR1 out and move on (to AR2) without many other changes. In other
>> words,
>> can we put this off to AR2?
>
> As I pointed out originally, it is something that doesn't need to
> hold up the
> current release, but something I would like to see in the future to
> receive
> my +1 vote.
>
> Cheers
> --
> Niclas Hedhman, Software Developer
>
> I live here; http://tinyurl.com/2qq9er
> I work here; http://tinyurl.com/2ymelc
> I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Friday 04 January 2008 11:45, Jim Hurley wrote:
> I understand (and agree) with Niclas' point - but honestly hoping we
> can get
> AR1 out and move on (to AR2) without many other changes. In other
> words,
> can we put this off to AR2?
As I pointed out originally, it is something that doesn't need to hold up the
current release, but something I would like to see in the future to receive
my +1 vote.
Cheers
--
Niclas Hedhman, Software Developer
I live here; http://tinyurl.com/2qq9er
I work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Jan 4, 2008 5:45 AM, Jim Hurley <ji...@mac.com> wrote:
> Any words of advice from those more familiar with Apache incubator
> releases? Is this (including "incubating" in the directory name,
> basically matching the download name), common practice?
It's a common practice to have the name of the packaged directory
match the name of the package, i.e.
apache-river-2.1.1-incubating-src.zip to apache-river-2.1.1-incubating
(or even apache-river-2.1.1-incubating-src).
> Or an ASF requirement?
No.
> I understand (and agree) with Niclas' point - but honestly hoping we
> can get AR1 out and move on (to AR2) without many other changes.
> In other words, can we put this off to AR2?
Yes.
BR,
Jukka Zitting
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <ji...@mac.com>.
On Dec 30, 2007, at 11:33 PM, Niclas Hedhman wrote:
> :
> * As I mentioned before, if the version (classifier) contains
> "incubating"
> (which we recommend), so that the directory itself has the name, I
> would
> be *more* pleased.
Any words of advice from those more familiar with Apache incubator
releases? Is this (including "incubating" in the directory name,
basically
matching the download name), common practice? Or an ASF requirement?
I understand (and agree) with Niclas' point - but honestly hoping we
can get
AR1 out and move on (to AR2) without many other changes. In other
words,
can we put this off to AR2?
Thanks for any help.
-Jim
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <ji...@mac.com>.
Thanks for the feedback, Niclas.
Agree that these are things to consider for the next release -- would
welcome it if you filed a JIRA issue. Otherwise, I'll try and get to
it.
-Jim
On Dec 30, 2007, at 11:33 PM, Niclas Hedhman wrote:
> On Thursday 27 December 2007 21:52, Frank Barnaby wrote:
>> I've uploaded the bundles to my area:
>>
>> http://people.apache.org/~fbarnaby/river/2.1.1/
>
> This release would get my vote, subject to the RAT report which I
> have not run
> yet. The Incubator PMC is eternally grateful if the RAT report is
> published
> as well.
>
> A few further things for future;
>
> * The Notice mentions that the release contains Copyrighted material
> from Sun
> Microsystems. That is Ok, but it should also mention that Sun has
> licensed
> this to ASF under ALv2.
>
> * The Notice mentions the Service UI project, developed by several
> individuals, but doesn't mention any licensing. If the ServiceUI
> was ALv2
> from the beginning, then mention that. If it was something else, I
> think
> that could possibly be an encumbered codebase, depending on
> circumstances.
> I suggest that the Mentor(s) list this for investigation, and
> clarify the
> result both in the incubating status file as well as in the NOTICE.
>
> * As I mentioned before, if the version (classifier) contains
> "incubating"
> (which we recommend), so that the directory itself has the name, I
> would
> be *more* pleased.
>
> Cheers
> --
> Niclas Hedhman, Software Developer
>
> I live here; http://tinyurl.com/2qq9er
> I work here; http://tinyurl.com/2ymelc
> I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Dec 31, 2007 6:33 AM, Niclas Hedhman <ni...@hedhman.org> wrote:
> This release would get my vote, subject to the RAT report which I have not run
> yet. The Incubator PMC is eternally grateful if the RAT report is published
> as well.
Available at http://people.apache.org/~jukka/river/2.1.1/apache-river-2.1.1-incubating.rat
> * The Notice mentions that the release contains Copyrighted material from Sun
> Microsystems. That is Ok, but it should also mention that Sun has licensed
> this to ASF under ALv2.
Do we need to do that in the NOTICE file? I wouldn't mind doing that,
but should the NOTICE file carry the licensing histories as well as
copyright notices? The fact that the code is ALv2 licensed is already
stated in LICENSE and we have the paper trail for the contribution.
For example, the example NOTICE file at
http://www.apache.org/licenses/example-NOTICE.txt doesn't contain
licensing histories.
> * The Notice mentions the Service UI project, developed by several
> individuals, but doesn't mention any licensing. If the ServiceUI was ALv2
> from the beginning, then mention that. If it was something else, I think
> that could possibly be an encumbered codebase, depending on circumstances.
> I suggest that the Mentor(s) list this for investigation, and clarify the
> result both in the incubating status file as well as in the NOTICE.
See above. We have a software grant for the ServiceUI contribution
which makes it distributable under ALv2. Of course we could better
document the licensing history (previously under Sun Community Source
License), but I'm not sure it's necessary or even relevant.
BR,
Jukka Zitting
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Thursday 27 December 2007 21:52, Frank Barnaby wrote:
> I've uploaded the bundles to my area:
>
> http://people.apache.org/~fbarnaby/river/2.1.1/
This release would get my vote, subject to the RAT report which I have not run
yet. The Incubator PMC is eternally grateful if the RAT report is published
as well.
A few further things for future;
* The Notice mentions that the release contains Copyrighted material from Sun
Microsystems. That is Ok, but it should also mention that Sun has licensed
this to ASF under ALv2.
* The Notice mentions the Service UI project, developed by several
individuals, but doesn't mention any licensing. If the ServiceUI was ALv2
from the beginning, then mention that. If it was something else, I think
that could possibly be an encumbered codebase, depending on circumstances.
I suggest that the Mentor(s) list this for investigation, and clarify the
result both in the incubating status file as well as in the NOTICE.
* As I mentioned before, if the version (classifier) contains "incubating"
(which we recommend), so that the directory itself has the name, I would
be *more* pleased.
Cheers
--
Niclas Hedhman, Software Developer
I live here; http://tinyurl.com/2qq9er
I work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
Bob Scheifler wrote:
> But, since there's no longer an installer version, the
> doc/info-index.html page needs correcting, as it suggests
> that installed items depend on the features selected during
> installation, and lists classes, installverify and uninstall
> as items that could appear but no longer can.
Also source can no longer appear. And I guess now
DISCLAIMER, LICENSE and NOTICE should be added.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
Frank Barnaby wrote:
> the issue that Bob S. mentioned yesterday needs to be discussed:
>
>> IIRC, the 2.1 installer version had the option to create an
>> expanded classes/ directory. I assume it was intentional to
>> not include this directory in the binary release.
>
>
> Note that adding the expanded classes directory will add 2.8 Mb
> to the binary bundle (9.6Mb -> 12.4Mb).
No need to add it on my account, leaving it out is consistent
with the non-installer zip file that we provided in 2.1.
But, since there's no longer an installer version, the
doc/info-index.html page needs correcting, as it suggests
that installed items depend on the features selected during
installation, and lists classes, installverify and uninstall
as items that could appear but no longer can.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
Mark Brouwer wrote:
> No top-level doc directory and a BUILDING.txt (only included in the
> source distribution) that mentions that the actual build instructions
> can be found in source/doc/build.html would solve this.
Just no top-level doc directory would be fine with me, and
preferable to the current state. It's not that hard to
find source/doc/build.html.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Mark Brouwer <ma...@cheiron.org>.
Bob Scheifler wrote:
> Perhaps I missed some discussion, but I'm confused why the
> source bundle contains fully generated api and spec javadoc trees?
> In fact, should it have a top-level doc directory at all?
> Seems wrong to me. Perhaps it's to make the top-level
It was my impression that we wanted to keep the reorganization of
the distributions to a minimum so that when the source and binary
distribution is overlayed you end up with the same layout as the JTSK
distribution. I think that requirement is responsible for the somewhat
odd layout, at least compared to how the average Apache project provides
its binary and source distribution.
> index.html functional if you don't download and overlay the
> binary release, but that seems pretty hacky to me.
No top-level doc directory and a BUILDING.txt (only included in the
source distribution) that mentions that the actual build instructions
can be found in source/doc/build.html would solve this. For me no need
to do this as part of AR1, but an example BUILDING.txt is attached.
B.T.W. building from the source distribution is OK now.
--
Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
Perhaps I missed some discussion, but I'm confused why the
source bundle contains fully generated api and spec javadoc trees?
In fact, should it have a top-level doc directory at all?
Seems wrong to me. Perhaps it's to make the top-level
index.html functional if you don't download and overlay the
binary release, but that seems pretty hacky to me.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
Frank Barnaby wrote:
> I've uploaded the bundles to my area:
>
> http://people.apache.org/~fbarnaby/river/2.1.1/
The build.release target works for me under Vista.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
I've uploaded the bundles to my area:
http://people.apache.org/~fbarnaby/river/2.1.1/
but my changes (in source and bundles) need to be reviewed,
and the issue that Bob S. mentioned yesterday needs to be
discussed:
> IIRC, the 2.1 installer version had the option to create an
> expanded classes/ directory. I assume it was intentional to
> not include this directory in the binary release.
Note that adding the expanded classes directory will add 2.8 Mb
to the binary bundle (9.6Mb -> 12.4Mb). Adding the classes dir
would involve an additional delay for discussion, build script
changes, possible doc changes, build, testing, and review.
If the increased size is unacceptable, two alternatives would be
to add a note about expanding the classes dir or just leave the
classes dir out of the bundle.
Frank
On Dec 27, 2007, at 08:16, Jim Hurley wrote:
> On Dec 26, 2007, at 12:29 PM, Frank Barnaby wrote:
> :
>> :
>> Unless I hear otherwise, I'll move forward on the release with
>> the added disclaimer and build fixes previously discussed.
>>
>> Also note that I'll be publishing the release candidate in my
>> Apache People area:
>>
>> http://people.apache.org/~fbarnaby/river/2.1.1/
>>
>> Jim H, I have a copy of the now obsolete release-candidate:
>>
>> http://people.apache.org/~fbarnaby/river/2.1.1/obsolete/
>>
>> Please remove your copy to prevent any confusion.
>
> Done. Thanks Frank.
>
> When you get the release candidate posted -- please send out
> a note so we can restart a vote.
>
> -Jim
>
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <Ji...@Sun.COM>.
On Dec 26, 2007, at 12:29 PM, Frank Barnaby wrote:
:
> :
> Unless I hear otherwise, I'll move forward on the release with
> the added disclaimer and build fixes previously discussed.
>
> Also note that I'll be publishing the release candidate in my
> Apache People area:
>
> http://people.apache.org/~fbarnaby/river/2.1.1/
>
> Jim H, I have a copy of the now obsolete release-candidate:
>
> http://people.apache.org/~fbarnaby/river/2.1.1/obsolete/
>
> Please remove your copy to prevent any confusion.
Done. Thanks Frank.
When you get the release candidate posted -- please send out
a note so we can restart a vote.
-Jim
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
I don't believe it was considered for AR1.
Frank
On Dec 26, 2007, at 15:48, Bob Scheifler wrote:
> IIRC, the 2.1 installer version had the option to create an
> expanded classes/ directory. I assume it was intentional to
> not include this directory in the binary release.
>
> - Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Bob Scheifler <Bo...@Sun.COM>.
IIRC, the 2.1 installer version had the option to create an
expanded classes/ directory. I assume it was intentional to
not include this directory in the binary release.
- Bob
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Craig L Russell <Cr...@Sun.COM>.
Hi Frank,
On Dec 26, 2007, at 9:29 AM, Frank Barnaby wrote:
>
> On Dec 24, 2007, at 06:23, Mark Brouwer wrote:
>
>> Hi Frank,
>>
>> Frank Barnaby wrote:
>>
>>> The top-level doc directory in the source release contains
>>> build.html, which provides a few instructions for building. That
>>> location was sufficient when we did not provide a release-build
>>> target. Now that such a target is available to the end users,
>>> however, the source release should also contain the build.html file.
>>> This issue also illuminates the need for a few other doc files to
>>> be added to the source sub-directory of the source release-bundle
>>> in support of end-user release builds.
>>
>> Most OS projects I'm aware of have a BUILD(ING).txt for this
>> purpose in the root, expectations are with many that there is a
>> README and the aforementioned file in the root of the
>> distribution. There is a build.html in the doc directory which is
>> referred to from the index.html but I'm afraid I fall in the
>> category that gives up easily too and resorts to its own
>> interpretation of the build files based on 'ant -projecthelp'.
>> Probably some more reorganization to bring it in line with common
>> practices could be beneficial for the future.
>
>
> It seems like a JIRA issue should be created for the above
> items, but I don't think the release should be modified and/or
> delayed to address this issue.
I agree.
Craig
>
> Unless I hear otherwise, I'll move forward on the release with
> the added disclaimer and build fixes previously discussed.
>
> Also note that I'll be publishing the release candidate in my
> Apache People area:
>
> http://people.apache.org/~fbarnaby/river/2.1.1/
>
> Jim H, I have a copy of the now obsolete release-candidate:
>
> http://people.apache.org/~fbarnaby/river/2.1.1/obsolete/
>
> Please remove your copy to prevent any confusion.
>
>
> Frank
>
>
>
>>
>>
>>> The "javac-cmd" macro-def already contains "source=1.4", and I
>>> believe that option has been included since at least version 2.0.
>>> Am I missing something here?
>>
>> No, it is me missing goggles and having a wrong understanding that
>> source="1.4" would make the warnings go away, while apparently the
>> only
>> solution is to resort to 1.4.2 or remove enum from the source as
>> will be
>> done as part of RIVER-212. Sorry for bringing this up here.
>>
>>> Thank you--I appreciate the offer. So far, the changes are simple
>>> enough for me to handle in short order. In fact, most of the work
>>> is already complete. Though, I would appreciate a review after I
>>> commit the changes and extra eyes to examine the resulting bundles.
>>
>> Will do that.
>> --
>> Mark
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
On Dec 24, 2007, at 06:23, Mark Brouwer wrote:
> Hi Frank,
>
> Frank Barnaby wrote:
>
>> The top-level doc directory in the source release contains
>> build.html, which provides a few instructions for building. That
>> location was sufficient when we did not provide a release-build
>> target. Now that such a target is available to the end users,
>> however, the source release should also contain the build.html file.
>> This issue also illuminates the need for a few other doc files to
>> be added to the source sub-directory of the source release-bundle
>> in support of end-user release builds.
>
> Most OS projects I'm aware of have a BUILD(ING).txt for this purpose
> in the root, expectations are with many that there is a README and
> the aforementioned file in the root of the distribution. There is a
> build.html in the doc directory which is referred to from the
> index.html but I'm afraid I fall in the category that gives up
> easily too and resorts to its own interpretation of the build files
> based on 'ant -projecthelp'. Probably some more reorganization to
> bring it in line with common practices could be beneficial for the
> future.
It seems like a JIRA issue should be created for the above
items, but I don't think the release should be modified and/or
delayed to address this issue.
Unless I hear otherwise, I'll move forward on the release with
the added disclaimer and build fixes previously discussed.
Also note that I'll be publishing the release candidate in my
Apache People area:
http://people.apache.org/~fbarnaby/river/2.1.1/
Jim H, I have a copy of the now obsolete release-candidate:
http://people.apache.org/~fbarnaby/river/2.1.1/obsolete/
Please remove your copy to prevent any confusion.
Frank
>
>
>> The "javac-cmd" macro-def already contains "source=1.4", and I
>> believe that option has been included since at least version 2.0.
>> Am I missing something here?
>
> No, it is me missing goggles and having a wrong understanding that
> source="1.4" would make the warnings go away, while apparently the
> only
> solution is to resort to 1.4.2 or remove enum from the source as
> will be
> done as part of RIVER-212. Sorry for bringing this up here.
>
>> Thank you--I appreciate the offer. So far, the changes are simple
>> enough for me to handle in short order. In fact, most of the work
>> is already complete. Though, I would appreciate a review after I
>> commit the changes and extra eyes to examine the resulting bundles.
>
> Will do that.
> --
> Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Mark Brouwer <ma...@cheiron.org>.
Hi Frank,
Frank Barnaby wrote:
> The top-level doc directory in the source release contains
> build.html, which provides a few instructions for building. That
> location was sufficient when we did not provide a release-build
> target. Now that such a target is available to the end users,
> however, the source release should also contain the build.html file.
> This issue also illuminates the need for a few other doc files to
> be added to the source sub-directory of the source release-bundle
> in support of end-user release builds.
Most OS projects I'm aware of have a BUILD(ING).txt for this purpose in
the root, expectations are with many that there is a README and the
aforementioned file in the root of the distribution. There is a
build.html in the doc directory which is referred to from the index.html
but I'm afraid I fall in the category that gives up easily too and
resorts to its own interpretation of the build files based on 'ant
-projecthelp'. Probably some more reorganization to bring it in line
with common practices could be beneficial for the future.
> The "javac-cmd" macro-def already contains "source=1.4", and I
> believe that option has been included since at least version 2.0.
> Am I missing something here?
No, it is me missing goggles and having a wrong understanding that
source="1.4" would make the warnings go away, while apparently the only
solution is to resort to 1.4.2 or remove enum from the source as will be
done as part of RIVER-212. Sorry for bringing this up here.
> Thank you--I appreciate the offer. So far, the changes are simple
> enough for me to handle in short order. In fact, most of the work
> is already complete. Though, I would appreciate a review after I
> commit the changes and extra eyes to examine the resulting bundles.
Will do that.
--
Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jim Hurley <Ji...@Sun.COM>.
Thank you, Frank, for the effort... and everyone who has contributed
to the discussion.
Seems like a respin is our best course of action for the project --
so let's cancel the ongoing vote until we have a new candidate.
thanks -Jim
On Dec 24, 2007, at 4:00 AM, Frank Barnaby wrote:
> On Dec 23, 2007, at 17:39, Mark Brouwer wrote:
>
>> Frank Barnaby wrote:
>>> To be clear, the classes and jars both build fine by using the
>>> "all" and "jars" ant targets. The javadoc no longer builds for
>>> the end user because of the addition of the url pointing to the
>>> NOTICE file to allow for stand-alone javadoc distributions. The
>>> release zip files also cannot be generated through the use of the
>>> "build.release" target. While the javadoc should build for the
>>> end user, we never intended the end user to build release
>>> bundles. However, I think it looks bad to have a build target
>>> that fails for the end user--I agree that we should either fix it
>>> or remove it from the end user build scripts.
>>> By fixing the javadoc end-user build, the release build will be
>>> fixed as well. The fix will require me to add the NOTICE and
>>> LICENSE files to the source sub-directory in the source
>>> distribution. Note that the source distribution already contains
>>> the NOTICE and LICENSE files in the top level, but the doc and
>>> release builds are not aware of those top-level files. After
>>> committing the changes, I'll generate another release, another
>>> set of corresponding signature and check-sum files, upload the
>>> files to people-apache.org, some folks can do some sanity tests,
>>> and we can start another vote. Did I overlook any steps?
>>> Is this course of action we want to pursue?
>>
>> Hi Frank,
>>
>> I did indeed build with build.release because I believe an end user
>> should be able to build a release as well.
>>
>> Also as I'm a newbie with regard to building the JTSK (I'm a source
>> consumer), as there is no README or build instruction file (something
>> for AR2?) it was unclear as what build targets I was supposed to
>> execute
>> (besides the default of 'all').
>>
>
>
> The top-level doc directory in the source release contains
> build.html, which provides a few instructions for building. That
> location was sufficient when we did not provide a release-build
> target. Now that such a target is available to the end users,
> however, the source release should also contain the build.html file.
> This issue also illuminates the need for a few other doc files to
> be added to the source sub-directory of the source release-bundle
> in support of end-user release builds.
>
>
>>
>> I would fix it by copying the NOTICE and LICENSE files into the
>> source
>> distribution, while doing that I would also add source="1.4" in the
>> javac tasks in the the build files because I was kind of irritated by
>> that one too and had to set my JAVA_HOME to an 1.4.2 JDK (this is not
>> a complete fix for RIVER-212 but it is just 60 seconds of work and
>> prevents from other people being confronted with the issue until
>> AR2 is
>> out the door for which we don't know how long it takes).
>>
>
>
> The "javac-cmd" macro-def already contains "source=1.4", and I
> believe that option has been included since at least version 2.0.
> Am I missing something here?
>
>
>>
>> I also would suggest to fix Niclas's issue because otherwise no doubt
>> this issue pops up during the vote for Incubator and we don't know
>> the
>> outcome.
>>
>
>
> I agree--it's a simple addition and would provide a useful level
> of clarity. Is there an Apache template for such a disclaimer or
> should we simply create the file from scratch, basing it on project
> Wicket's disclaimer?
>
>
>>
>> If you need a hand, let me know so I can help out.
>>
>
>
>
> Thank you--I appreciate the offer. So far, the changes are simple
> enough for me to handle in short order. In fact, most of the work
> is already complete. Though, I would appreciate a review after I
> commit the changes and extra eyes to examine the resulting bundles.
>
>
>
> Frank
>
>
>
>>
>> --
>> Mark
>
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
Thank you Jukka for locating the template. Unless I hear
otherwise, I'll be using the following disclaimer for River:
Apache River is an effort undergoing incubation at The Apache Software
Foundation (ASF), sponsored by the Apache Incubator PMC. Incubation is
required of all newly accepted projects until a further review
indicates that the infrastructure, communications, and decision making
process have stabilized in a manner consistent with other successful
ASF projects. While incubation status is not necessarily a reflection
of the completeness or stability of the code, it does indicate that
the project has yet to be fully endorsed by the ASF.
Frank
On Dec 24, 2007, at 11:07, Craig L Russell wrote:
>
> On Dec 24, 2007, at 1:12 AM, Jukka Zitting wrote:
>
>> See http://incubator.apache.org/guides/branding.html. Use the
>> following text:
>>
>> ----
>> Apache River is an effort undergoing incubation at The Apache
>> Software
>> Foundation (ASF), sponsored by the
>
>> name of sponsor.
> Actually, the Incubator
>
>> Incubation is
>> required of all newly accepted projects until a further review
>> indicates that the infrastructure, communications, and decision
>> making
>> process have stabilized in a manner consistent with other successful
>> ASF projects. While incubation status is not necessarily a reflection
>> of the completeness or stability of the code, it does indicate that
>> the project has yet to be fully endorsed by the ASF.
>
> Craig
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Craig L Russell <Cr...@Sun.COM>.
On Dec 24, 2007, at 1:12 AM, Jukka Zitting wrote:
> See http://incubator.apache.org/guides/branding.html. Use the
> following text:
>
> ----
> Apache River is an effort undergoing incubation at The Apache Software
> Foundation (ASF), sponsored by the
> name of sponsor.
Actually, the Incubator
> Incubation is
> required of all newly accepted projects until a further review
> indicates that the infrastructure, communications, and decision making
> process have stabilized in a manner consistent with other successful
> ASF projects. While incubation status is not necessarily a reflection
> of the completeness or stability of the code, it does indicate that
> the project has yet to be fully endorsed by the ASF.
Craig
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Dec 24, 2007 11:00 AM, Frank Barnaby <Fr...@sun.com> wrote:
> On Dec 23, 2007, at 17:39, Mark Brouwer wrote:
> > I also would suggest to fix Niclas's issue because otherwise no doubt
> > this issue pops up during the vote for Incubator and we don't know the
> > outcome.
>
> I agree--it's a simple addition and would provide a useful level
> of clarity.
+1 Let's do this.
> Is there an Apache template for such a disclaimer or
> should we simply create the file from scratch, basing it on project
> Wicket's disclaimer?
See http://incubator.apache.org/guides/branding.html. Use the following text:
----
Apache River is an effort undergoing incubation at The Apache Software
Foundation (ASF), sponsored by the name of sponsor. Incubation is
required of all newly accepted projects until a further review
indicates that the infrastructure, communications, and decision making
process have stabilized in a manner consistent with other successful
ASF projects. While incubation status is not necessarily a reflection
of the completeness or stability of the code, it does indicate that
the project has yet to be fully endorsed by the ASF.
----
BR,
Jukka Zitting
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
On Dec 23, 2007, at 17:39, Mark Brouwer wrote:
> Frank Barnaby wrote:
>> To be clear, the classes and jars both build fine by using the
>> "all" and "jars" ant targets. The javadoc no longer builds for the
>> end user because of the addition of the url pointing to the NOTICE
>> file to allow for stand-alone javadoc distributions. The release
>> zip files also cannot be generated through the use of the
>> "build.release" target. While the javadoc should build for the end
>> user, we never intended the end user to build release bundles.
>> However, I think it looks bad to have a build target that fails for
>> the end user--I agree that we should either fix it or remove it
>> from the end user build scripts.
>> By fixing the javadoc end-user build, the release build will be
>> fixed as well. The fix will require me to add the NOTICE and
>> LICENSE files to the source sub-directory in the source
>> distribution. Note that the source distribution already contains
>> the NOTICE and LICENSE files in the top level, but the doc and
>> release builds are not aware of those top-level files. After
>> committing the changes, I'll generate another release, another set
>> of corresponding signature and check-sum files, upload the files to
>> people-apache.org, some folks can do some sanity tests, and we can
>> start another vote. Did I overlook any steps?
>> Is this course of action we want to pursue?
>
> Hi Frank,
>
> I did indeed build with build.release because I believe an end user
> should be able to build a release as well.
>
> Also as I'm a newbie with regard to building the JTSK (I'm a source
> consumer), as there is no README or build instruction file (something
> for AR2?) it was unclear as what build targets I was supposed to
> execute
> (besides the default of 'all').
>
The top-level doc directory in the source release contains
build.html, which provides a few instructions for building. That
location was sufficient when we did not provide a release-build
target. Now that such a target is available to the end users,
however, the source release should also contain the build.html file.
This issue also illuminates the need for a few other doc files to
be added to the source sub-directory of the source release-bundle
in support of end-user release builds.
>
> I would fix it by copying the NOTICE and LICENSE files into the source
> distribution, while doing that I would also add source="1.4" in the
> javac tasks in the the build files because I was kind of irritated by
> that one too and had to set my JAVA_HOME to an 1.4.2 JDK (this is not
> a complete fix for RIVER-212 but it is just 60 seconds of work and
> prevents from other people being confronted with the issue until AR2
> is
> out the door for which we don't know how long it takes).
>
The "javac-cmd" macro-def already contains "source=1.4", and I
believe that option has been included since at least version 2.0.
Am I missing something here?
>
> I also would suggest to fix Niclas's issue because otherwise no doubt
> this issue pops up during the vote for Incubator and we don't know the
> outcome.
>
I agree--it's a simple addition and would provide a useful level
of clarity. Is there an Apache template for such a disclaimer or
should we simply create the file from scratch, basing it on project
Wicket's disclaimer?
>
> If you need a hand, let me know so I can help out.
>
Thank you--I appreciate the offer. So far, the changes are simple
enough for me to handle in short order. In fact, most of the work
is already complete. Though, I would appreciate a review after I
commit the changes and extra eyes to examine the resulting bundles.
Frank
>
> --
> Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Mark Brouwer <ma...@cheiron.org>.
Frank Barnaby wrote:
>
> To be clear, the classes and jars both build fine by using the "all" and
> "jars" ant targets. The javadoc no longer builds for the end user
> because of the addition of the url pointing to the NOTICE file to allow
> for stand-alone javadoc distributions. The release zip files also
> cannot be generated through the use of the "build.release" target.
> While the javadoc should build for the end user, we never intended the
> end user to build release bundles. However, I think it looks bad to
> have a build target that fails for the end user--I agree that we should
> either fix it or remove it from the end user build scripts.
>
> By fixing the javadoc end-user build, the release build will be fixed as
> well. The fix will require me to add the NOTICE and LICENSE files to
> the source sub-directory in the source distribution. Note that the
> source distribution already contains the NOTICE and LICENSE files in the
> top level, but the doc and release builds are not aware of those
> top-level files. After committing the changes, I'll generate another
> release, another set of corresponding signature and check-sum files,
> upload the files to people-apache.org, some folks can do some sanity
> tests, and we can start another vote. Did I overlook any steps?
>
> Is this course of action we want to pursue?
Hi Frank,
I did indeed build with build.release because I believe an end user
should be able to build a release as well.
Also as I'm a newbie with regard to building the JTSK (I'm a source
consumer), as there is no README or build instruction file (something
for AR2?) it was unclear as what build targets I was supposed to execute
(besides the default of 'all').
I would fix it by copying the NOTICE and LICENSE files into the source
distribution, while doing that I would also add source="1.4" in the
javac tasks in the the build files because I was kind of irritated by
that one too and had to set my JAVA_HOME to an 1.4.2 JDK (this is not
a complete fix for RIVER-212 but it is just 60 seconds of work and
prevents from other people being confronted with the issue until AR2 is
out the door for which we don't know how long it takes).
I also would suggest to fix Niclas's issue because otherwise no doubt
this issue pops up during the vote for Incubator and we don't know the
outcome.
If you need a hand, let me know so I can help out.
--
Mark
Re: VOTING ISSUE with apache-river-2.1.1-incubating
Posted by Frank Barnaby <Fr...@Sun.COM>.
To be clear, the classes and jars both build fine by using the "all"
and "jars" ant targets. The javadoc no longer builds for the end user
because of the addition of the url pointing to the NOTICE file to
allow for stand-alone javadoc distributions. The release zip files
also cannot be generated through the use of the "build.release"
target. While the javadoc should build for the end user, we never
intended the end user to build release bundles. However, I think it
looks bad to have a build target that fails for the end user--I agree
that we should either fix it or remove it from the end user build
scripts.
By fixing the javadoc end-user build, the release build will be fixed
as well. The fix will require me to add the NOTICE and LICENSE files
to the source sub-directory in the source distribution. Note that the
source distribution already contains the NOTICE and LICENSE files in
the top level, but the doc and release builds are not aware of those
top-level files. After committing the changes, I'll generate another
release, another set of corresponding signature and check-sum files,
upload the files to people-apache.org, some folks can do some sanity
tests, and we can start another vote. Did I overlook any steps?
Is this course of action we want to pursue?
Frank
On Dec 23, 2007, at 14:16, Mark Brouwer wrote:
> Lately I was too entangled in trying to verify whether Frank is really
> who he says he is and therefore I haven't tested the distributions
> other
> than building from SVN.
>
> Before voting I tried to build from the source and I can't due to:
>
> BUILD FAILED
> D:\tmp\apache-river-2.1.1\source\build_common.xml:877: Warning: Could
> not find file D:\tmp\apache-river-2.1.1\source\NOTICE to copy.
>
> I think we shouldn't release a source distribution that doesn't
> actually
> build. But before voting I would like to know whether we can fix this
> issue after we approved the release and before presenting a
> distribution
> to Incubator. I hope so because I don't want to spoil the party.
> --
> Mark
>