You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/28 01:19:25 UTC
[GitHub] [spark] c21 opened a new pull request #29566: [SPARK-32629] Track metrics of BitSet/OpenHashSet in full outer SHJ
c21 opened a new pull request #29566:
URL: https://github.com/apache/spark/pull/29566
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is followup from https://github.com/apache/spark/pull/29342, where to do two things:
* Per https://github.com/apache/spark/pull/29342#discussion_r470153323, change from java `HashSet` to spark in-house `OpenHashSet` to track matched rows for non-unique join keys. I checked `OpenHashSet` implementation which is built from a key index array and `BitSet`. Java `HashSet` is built from `HashMap`, which stores value in `Node` linked list and by theory should have taken more memory than `OpenHashSet`.
* Track metrics of the extra data structure `BitSet`/`OpenHashSet` for full outer SHJ. This depends on above thing, because there seems no easy way to get java `HashSet` memory size.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To better surface the memory usage for full outer SHJ more accurately.
This can help users/developers to debug/improve full outer SHJ.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unite test in `SQLMetricsSuite.scala` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478961374
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -136,10 +134,10 @@ case class ShuffledHashJoinExec(
* Full outer shuffled hash join with unique join keys:
* 1. Process rows from stream side by looking up hash relation.
* Mark the matched rows from build side be looked up.
- * A `BitSet` is used to track matched rows with key index.
+ * A [[BitSet]] is used to track matched rows with key index.
Review comment:
@cloud-fan - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -136,10 +134,10 @@ case class ShuffledHashJoinExec(
* Full outer shuffled hash join with unique join keys:
* 1. Process rows from stream side by looking up hash relation.
* Mark the matched rows from build side be looked up.
- * A `BitSet` is used to track matched rows with key index.
+ * A [[BitSet]] is used to track matched rows with key index.
Review comment:
@cloud-fan - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -150,9 +148,9 @@ case class ShuffledHashJoinExec(
streamNullJoinRowWithBuild: => InternalRow => JoinedRow,
buildNullRow: GenericInternalRow,
streamNullRow: GenericInternalRow): Iterator[InternalRow] = {
- // TODO(SPARK-32629):record metrics of extra BitSet/HashSet
- // in full outer shuffled hash join
val matchedKeys = new BitSet(hashedRelation.maxNumKeysIndex)
+ val buildDataSize = longMetric("buildDataSize")
+ buildDataSize += matchedKeys.capacity / 8
Review comment:
@maropu - sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682418854
Address all comments and PR is ready for review again, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29566: [SPARK-32629][SQL][FOLLOWUP] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682279346
Looks okay if the tests pass. also cc: @agrawaldevesh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682413881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682280196
Basically, we don't need the `[FOLLOWUP]` tag for a new ticket, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29566: [SPARK-32629] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682272868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682575684
**[Test build #127992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127992/testReport)** for PR 29566 at commit [`b932caa`](https://github.com/apache/spark/commit/b932caad400db1c5ace2cbba9318e8f97bbdd24e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682272539
**[Test build #127975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127975/testReport)** for PR 29566 at commit [`4a35fa6`](https://github.com/apache/spark/commit/4a35fa6f3d7e9abb09e470e4fe5162161dce90f3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29566: [SPARK-32629] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682272868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29566: [SPARK-32629][SQL][FOLLOWUP] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478786889
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsTestUtils.scala
##########
@@ -254,6 +254,24 @@ trait SQLMetricsTestUtils extends SQLTestUtils {
}
}
}
+
+ /**
+ * Verify if the metrics in `SparkPlan` operator are same as expected metrics.
+ *
+ * @param plan `SparkPlan` operator to check metrics
+ * @param expectedMetrics the expected metrics. The format is `metric name -> metric value`.
+ */
+ protected def testMetricsInSparkPlanOperator(
Review comment:
@maropu - I am following the convention like other method e.g. `testSparkPlanMetrics`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29566: [SPARK-32629][SQL][FOLLOWUP] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478785918
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsTestUtils.scala
##########
@@ -254,6 +254,24 @@ trait SQLMetricsTestUtils extends SQLTestUtils {
}
}
}
+
+ /**
+ * Verify if the metrics in `SparkPlan` operator are same as expected metrics.
+ *
+ * @param plan `SparkPlan` operator to check metrics
+ * @param expectedMetrics the expected metrics. The format is `metric name -> metric value`.
+ */
+ protected def testMetricsInSparkPlanOperator(
Review comment:
We need to put this func here instead of `SQLMetricsSuite`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29566: [SPARK-32629] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682272539
**[Test build #127975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127975/testReport)** for PR 29566 at commit [`4a35fa6`](https://github.com/apache/spark/commit/4a35fa6f3d7e9abb09e470e4fe5162161dce90f3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-683348546
Thanks @maropu , @cloud-fan and @agrawaldevesh for discussion and review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682345843
**[Test build #127975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127975/testReport)** for PR 29566 at commit [`4a35fa6`](https://github.com/apache/spark/commit/4a35fa6f3d7e9abb09e470e4fe5162161dce90f3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478828989
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -136,10 +134,10 @@ case class ShuffledHashJoinExec(
* Full outer shuffled hash join with unique join keys:
* 1. Process rows from stream side by looking up hash relation.
* Mark the matched rows from build side be looked up.
- * A `BitSet` is used to track matched rows with key index.
+ * A [[BitSet]] is used to track matched rows with key index.
Review comment:
nit: just say `A bit set is ...` to be generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29566: [SPARK-32629][SQL][FOLLOWUP] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478786318
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -150,9 +148,9 @@ case class ShuffledHashJoinExec(
streamNullJoinRowWithBuild: => InternalRow => JoinedRow,
buildNullRow: GenericInternalRow,
streamNullRow: GenericInternalRow): Iterator[InternalRow] = {
- // TODO(SPARK-32629):record metrics of extra BitSet/HashSet
- // in full outer shuffled hash join
val matchedKeys = new BitSet(hashedRelation.maxNumKeysIndex)
+ val buildDataSize = longMetric("buildDataSize")
+ buildDataSize += matchedKeys.capacity / 8
Review comment:
nit: `longMetric("buildDataSize") += matchedKeys.capacity / 8`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478828677
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -136,10 +134,10 @@ case class ShuffledHashJoinExec(
* Full outer shuffled hash join with unique join keys:
* 1. Process rows from stream side by looking up hash relation.
* Mark the matched rows from build side be looked up.
- * A `BitSet` is used to track matched rows with key index.
+ * A [[BitSet]] is used to track matched rows with key index.
Review comment:
nit: just say `A bit set is ...` to be generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29566:
URL: https://github.com/apache/spark/pull/29566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682280358
> Basically, we don't need the [FOLLOWUP] tag for a new ticket, I think.
@maropu - cool, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682413881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682576822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682418037
> So any improvement in either memory usage, GC, or CPU time by switching to open hashset ?
@agrawaldevesh - here is report for one production query internally which is doing a FULL OUTER JOIN for one large table, and one small table. Couldn't share the exact query text and data but the query shape is:
```sql
INSERT OVERWRITE TABLE output_table
PARTITION (...)
SELECT ...
FROM large_table a
FULL OUTER JOIN small_table b
ON a.col_x = f.col_y
```
input metrics:
large_table (ORC format): uncompressed data input size: 54TB
small_table (ORC format): uncompressed data input size: 85GB
execution metrics:
Number of tasks per stage:
stage 0: 40547 (read large table)
stage 1: 158 (read small table)
stage 2: 5063 (SHJ and insert to output table)
Total shuffle bytes across executors: 15.1TB.
Query type | Aggregated executors CPU time (ms) | Aggregated executors GC time (ms)
------------ | ------------- | -------------
use java `HashSet` | 3.48 B | 124.0 M
use spark `OpenHashSet` | 3.22 B | 91.2 M
TLDR is switching to `OpenHashSet`, we are seeing 7% CPU reduction and 27% GC time reduction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] agrawaldevesh commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
agrawaldevesh commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682282090
Wow, cool. So any improvement in either memory usage, GC, or CPU time by switching to open hashset ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682576822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-683346574
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29566: [SPARK-32629] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682271718
cc @maropu and @cloud-fan if you guys have time to take a look, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682346661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682413193
**[Test build #127992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127992/testReport)** for PR 29566 at commit [`b932caa`](https://github.com/apache/spark/commit/b932caad400db1c5ace2cbba9318e8f97bbdd24e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682346661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29566:
URL: https://github.com/apache/spark/pull/29566#issuecomment-682413193
**[Test build #127992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127992/testReport)** for PR 29566 at commit [`b932caa`](https://github.com/apache/spark/commit/b932caad400db1c5ace2cbba9318e8f97bbdd24e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org