[PR] test: cover arg validation, clear paths and refire in AlertStateMachine [rocketmq-dashboard]

["yyqdbngt (via GitHub)" <gi...@apache.org>]

yyqdbngt opened a new pull request, #3404:
URL: https://github.com/apache/rocketmq-dashboard/pull/3404

   ### Summary
   
   `AlertStateMachine` guards its inputs and distinguishes OK/ACKED/RESOLVED clear paths, but the suite only exercised PENDING/FIRING hits, reminders and unavailable samples.
   
   ### Changes
   
   - Non-positive `requiredConsecutiveSamples` and null/negative `requiredDuration` are rejected with descriptive messages
   - A non-matching sample leaves the firing state untouched
   - Clearing a sample while OK keeps the state OK with zero consecutive hits
   - An acknowledged alert clears to RESOLVED (recording `resolvedAt`) and ignores still-matching samples
   - A resolved alert can fire again on a new breach
   
   ### Testing
   
   `mvn test -Dtest=AlertStateMachineTest` passes: 14 tests, 0 failures (up from 7).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: cover arg validation, clear paths and refire in AlertStateMachine [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #3404: test: cover arg validation, clear paths and refire in AlertStateMachine
URL: https://github.com/apache/rocketmq-dashboard/pull/3404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org