[GitHub] [beam] chamikaramj commented on a change in pull request #11814: [BEAM-10078] uniquify Dataflow specific jars when staging

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #11814:
URL: https://github.com/apache/beam/pull/11814#discussion_r431387079



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##########
@@ -397,10 +397,21 @@ public static PackageAttributes forFileToStage(
             String.format("Non-existent file to stage: %s", file.getAbsolutePath()));
       }
       checkState(!file.isDirectory(), "Source file must not be a directory.");
+      String target;
+      switch (dest) {
+        case "dataflow-worker.jar":

Review comment:
       I'm not sure why we need special treatment for Dataflow jars here. Behavior for these jars should be similar for any other jars uploaded for Dataflow IMO.
   
   @lukecwik WDYT ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org