You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/04 00:06:17 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #42330: [SPARK-44664][PYTHON][CONNECT] Release the execute when closing the iterator in Python client

HyukjinKwon opened a new pull request, #42330:
URL: https://github.com/apache/spark/pull/42330

   ### What changes were proposed in this pull request?
   
   This PR implements the symmetry of https://github.com/apache/spark/pull/42304 and https://github.com/apache/spark/pull/42320. 
   
   1. It releases the execute when the error is raised during the iteration
   2. When you explicitly close the generator, (e.g., either `generator.close()` or explicit `GeneratorExit`), it releases the execution.
   
   ### Why are the changes needed?
   
   For the feature parity, see also https://github.com/apache/spark/pull/42320 and https://github.com/apache/spark/pull/42304
   
   ### Does this PR introduce _any_ user-facing change?
   
   See also https://github.com/apache/spark/pull/42320 and https://github.com/apache/spark/pull/42304
   
   ### How was this patch tested?
   
   Tests will be added separately.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42330: [SPARK-44664][PYTHON][CONNECT] Release the execute when closing the iterator in Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42330:
URL: https://github.com/apache/spark/pull/42330#issuecomment-1664906302

   Merged to master and branch-3.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42330: [SPARK-44664][PYTHON][CONNECT] Release the execute when closing the iterator in Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42330:
URL: https://github.com/apache/spark/pull/42330#issuecomment-1664782620

   cc @juliuszsompolski, @cdkrot, @zhengruifeng and @ueshin FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #42330: [SPARK-44664][PYTHON][CONNECT] Release the execute when closing the iterator in Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42330: [SPARK-44664][PYTHON][CONNECT] Release the execute when closing the iterator in Python client
URL: https://github.com/apache/spark/pull/42330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org