[GitHub] [echarts] sjw-id-pc commented on a diff in pull request #17499: fix:When the mouse moves out of the element, the timer should be clea…

[GitBox <gi...@apache.org>]

sjw-id-pc commented on code in PR #17499:
URL: https://github.com/apache/echarts/pull/17499#discussion_r944154565


##########
src/component/tooltip/TooltipView.ts:
##########
@@ -394,6 +394,7 @@ class TooltipView extends ComponentView {
         api: ExtensionAPI,
         payload: HideTipPayload
     ) {
+        clearTimeout(this._showTimout);

Review Comment:
   Thank you for your advice,your suggestion is very good.
   But it is unnecessary because we need to restart the timer after stopping it, not clear variable '_ Showtimout'.
   
   void WindowOrWorkerGlobalScope::clearTimeout(EventTarget& event_target,int timeout_id){}  Function of wrong type will not be executed.Therefore, no judgment is required.
   
   The biggest reason is that I am not familiar with Typescript, hahaha!!!
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org