[PR] Isolate Groovy compile-time dependencies [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #39664:
URL: https://github.com/apache/shardingsphere/pull/39664

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Isolate Groovy compile-time dependencies [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39664:
URL: https://github.com/apache/shardingsphere/pull/39664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Isolate Groovy compile-time dependencies [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #39664:
URL: https://github.com/apache/shardingsphere/pull/39664#issuecomment-5474750886

   ### Result
   
   **Review Result: Mergeable**
   
   No out-of-scope files, unrelated refactoring, or unintended behavior expansion were found. All 29 changed files directly support isolating Groovy compile-time dependencies or provide necessary regression protection.
   
   ### Evidence
   
   - GitHub’s authoritative file list matches the local `base...head` diff exactly: 29/29 files; merge base is `3f86f6804adc7199c4e0fe9f4fb49f7202b66707`.
   - Groovy imports were removed from all 19 affected files outside the Groovy module. The remaining changes establish the runtime dependency and exception boundary or test the affected behavior.
   - `infra/expr/entry/pom.xml:29` changes the Groovy implementation to runtime scope. Compile-scope dependency trees expose Groovy only within `infra/expr/type/groovy`, while the JDBC and Proxy distributions still include Groovy 4.0.22 at runtime.
   - The exception wrapping in `GroovyInlineExpressionParser.java:103` and translation in `InlineShardingAlgorithm.java:69` preserve the previous missing-method behavior.
   - The replacement escape handling in `KernelDistSQLStatementVisitor.java:139` matched Groovy 4.0.22 for 177,156 generated input combinations.
   - Focused tests passed: 13 Groovy expression tests, 10 inline sharding algorithm tests, and 252 DistSQL parser cases.
   - Test sources for all 16 affected Maven modules compiled successfully. Spotless and Checkstyle also passed.
   - No functional, compatibility, performance, packaging, or distribution regressions were found.
   
   ### Coverage
   
   - Candidate: [Public PR #39664](https://github.com/apache/shardingsphere/pull/39664)
   - Reviewed head: `98dd4a90f6165bd051398222f7c1d7fddb265fdf`
   - Authoritative requirement: PR title, “Isolate Groovy compile-time dependencies.” The PR has no description, linked issue, comments, or previous reviews.
   - Behavior clusters: Groovy runtime isolation and exception boundary; removal of Groovy utility references; preservation of DistSQL escape semantics.
   - Completed lenses: Root Cause and Behavior; Blast Radius and Contracts; Tests, Runtime, and Operations; final full-scope convergence pass.
   - File coverage: 29/29 files; no unreviewed or churn-only files and no unresolved evidence gaps.
   - This is a code-scope result only. CI was not reviewed under Code Correctness Review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org