You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/07/17 15:33:46 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2742: ARTEMIS-2409 Convert HornetQ field names in consumer/queue selector s…

clebertsuconic commented on a change in pull request #2742: ARTEMIS-2409 Convert HornetQ field names in consumer/queue selector s…
URL: https://github.com/apache/activemq-artemis/pull/2742#discussion_r304476612
 
 

 ##########
 File path: tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/jms/client/SelectorTranslatorTest.java
 ##########
 @@ -204,6 +204,37 @@ public void testParseJMSType() {
       checkNoSubstitute("JMSType");
    }
 
+   @Test
 
 Review comment:
   The proper test would been on the compatibility-tests
   
   
   I have added it as part of my merge. just letting you know for future reference.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services