You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by José Guilherme Vanz <gu...@gmail.com> on 2015/08/09 06:58:05 UTC

Review Request 37267: Style checker checking for { on newline

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.

This commit contains the files changed in the libprocess project


Diffs
-----

  3rdparty/libprocess/include/process/filter.hpp db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/metrics/metric.hpp c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/process.hpp bf8e2bf46fad2eae1c9f1b788b2b71305664e508 

Diff: https://reviews.apache.org/r/37267/diff/


Testing
-------


Thanks,

José Guilherme Vanz


Re: Review Request 37267: Style checker checking for { on newline

Posted by Jose Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 10:34 a.m.)


Review request for mesos.


Bugs: MESOS-2578
    https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description
-------

As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.

This commit contains the files changed in the libprocess project


Diffs
-----

  3rdparty/libprocess/include/process/filter.hpp db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/metrics/metric.hpp c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/process.hpp bf8e2bf46fad2eae1c9f1b788b2b71305664e508 

Diff: https://reviews.apache.org/r/37267/diff/


Testing
-------


Thanks,

Jose Guilherme Vanz


Re: Review Request 37267: Style checker checking for { on newline

Posted by José Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
-----------------------------------------------------------

(Updated Aug. 12, 2015, 1:16 a.m.)


Review request for mesos.


Bugs: MESOS-2578
    https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description (updated)
-------

As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.

This commit contains the files changed in the libprocess project


Diffs
-----

  3rdparty/libprocess/include/process/filter.hpp db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/metrics/metric.hpp c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/process.hpp bf8e2bf46fad2eae1c9f1b788b2b71305664e508 

Diff: https://reviews.apache.org/r/37267/diff/


Testing
-------


Thanks,

José Guilherme Vanz


Re: Review Request 37267: Style checker checking for { on newline

Posted by José Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
-----------------------------------------------------------

(Updated Aug. 12, 2015, 1:10 a.m.)


Review request for mesos.


Bugs: MESOS-2578
    https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description (updated)
-------

As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.

This commit contains the files changed in the libprocess project


Diffs
-----

  3rdparty/libprocess/include/process/filter.hpp db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/metrics/metric.hpp c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/process.hpp bf8e2bf46fad2eae1c9f1b788b2b71305664e508 

Diff: https://reviews.apache.org/r/37267/diff/


Testing
-------


Thanks,

José Guilherme Vanz


Re: Review Request 37267: Style checker checking for { on newline

Posted by José Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 1:47 a.m.)


Review request for mesos.


Bugs: MESOS-2578
    https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description
-------

As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.

This commit contains the files changed in the libprocess project


Diffs
-----

  3rdparty/libprocess/include/process/filter.hpp db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/metrics/metric.hpp c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/process.hpp bf8e2bf46fad2eae1c9f1b788b2b71305664e508 

Diff: https://reviews.apache.org/r/37267/diff/


Testing
-------


Thanks,

José Guilherme Vanz