[jira] [Commented] (FELIX-4734) Web Console RESTful API should wait for asynchonous operations until they complete

["Valentin Valchev (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253147#comment-14253147 ] 

Valentin Valchev commented on FELIX-4734:
-----------------------------------------

IMHO the web console shouldn't way at all, but you might be right, that it's more convenient that way.

Looking at the code, I think that web console waits all the time, but that completely unnecessary for install, start, stop..

But for sure - we should wait for refresh(bundle) and refreshPackages and probably update(bundle). And blind waiting is really not enough. So I'll think about it and propose a patch.

> Web Console RESTful API should wait for asynchonous operations until they complete 
> -----------------------------------------------------------------------------------
>
>                 Key: FELIX-4734
>                 URL: https://issues.apache.org/jira/browse/FELIX-4734
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-4.2.4
>            Reporter: Konrad Windszus
>
> Currently the RESTful API (http://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html) adds a delay of 800ms to the response to give the asynchronous operations enough time to complete successfully (https://github.com/apache/felix/blob/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java#L412).
> Instead the according listeners should be used which are notified upon completion of an asynchronous task.
> For {{refresh}} {{FrameworkWiring.refreshBundles}} can be used (http://www.osgi.org/javadoc/r4v43/core/org/osgi/framework/wiring/FrameworkWiring.html#refreshBundles%28java.util.Collection,%20org.osgi.framework.FrameworkListener...%29). A similar approach should be used for the other actions like uninstall, install, update, start, stop, ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)