You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/16 19:45:30 UTC

[GitHub] [hbase] busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch default garbage collector from CMS

busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409804666
 
 

 ##########
 File path: bin/hbase
 ##########
 @@ -136,6 +136,21 @@ if [ -f "$HBASE_HOME/conf/hbase-env-$COMMAND.sh" ]; then
   . "$HBASE_HOME/conf/hbase-env-$COMMAND.sh"
 fi
 
+# establish a default value for HBASE_OPTS if it's not already set. For now,
+# all we set is the garbage collector.
+if [ -z "${HBASE_OPTS}" ] ; then
+  major_version_number="$(parse_java_major_version "$(read_java_version)")"
+  case "$major_version_number" in
+  8|9|10)
+    HBASE_OPTS="-XX:+UseConcMarkSweepGC"
+    ;;
+  11|*)
+    HBASE_OPTS="-XX:+UseG1GC"
 
 Review comment:
   G1GC is the default, why aren't we just leaving this out?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services