[GitHub] [cordova-plugin-inappbrowser] kamilbrk opened a new pull request #515: fix #514

[GitBox <gi...@apache.org>]

kamilbrk opened a new pull request #515: fix #514
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/515
 
 
   ### Platforms affected
   
   TypeScript based Cordova projects.
   
   ### Motivation and Context
   
   Fixes #514.
   
   ### Description
   
   There was a regression in 3.1.0 since 3.0.0, whereby typings did not allow for an arbitrary `string` type for event listeners. In case your TypeScript project contains anything else extending `Window`, it would cause the build to fail.
   
   ### Testing
   
   Ran official 3.1.0 from apache, build failures as described in linked issue.
   Ran this fork, build succeeds.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass (just eslint?)
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org