You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/20 13:29:07 UTC
[GitHub] [superset] mayurnewase opened a new pull request #13255: refactor(connectors:sqla) : break generate sqla query
mayurnewase opened a new pull request #13255:
URL: https://github.com/apache/superset/pull/13255
### SUMMARY
First step toward cleaning sqla query generation.
Seperate get,update template args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase removed a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
mayurnewase removed a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782662953
@villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-783872068
@mayurnewase Thank you Mayur for contribution and collaboration!π please do add more description for project tracking and release purposes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `27.50%`.
> The diff coverage is `82.77%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 80.56% +27.50%
===========================================
Files 489 299 -190
Lines 17314 24176 +6862
Branches 4482 0 -4482
===========================================
+ Hits 9187 19477 +10290
+ Misses 8127 4699 -3428
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| python | `80.56% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ΓΈ> (ΓΈ)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.73% <ΓΈ> (ΓΈ)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.74% <4.34%> (ΓΈ)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `88.70% <16.66%> (ΓΈ)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.61% <27.27%> (ΓΈ)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <50.00%> (ΓΈ)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ΓΈ)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.41% <85.71%> (ΓΈ)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.26% <87.50%> (ΓΈ)` | |
| ... and [683 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782662953
@villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782830612
Hi, @mayurnewase , thank you for iterating on this. Could you complete the PR template and make sure to add a link to your [previous PR](https://github.com/apache/superset/pull/12482) for context?
I know it feels laborious and maybe meaningless, but following the PR template makes sure each PR is easily reviewable. You can just fill in `N/A` if some fields do not apply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (d9c0a69) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.48%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.54% +18.48%
===========================================
Files 489 767 +278
Lines 17314 40118 +22804
Branches 4482 4108 -374
===========================================
+ Hits 9187 28703 +19516
- Misses 8127 11415 +3288
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
| python | `80.16% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [495 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (d9c0a69) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.80%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.86% +18.80%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28851 +19664
- Misses 8127 11295 +3168
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
| python | `80.68% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [495 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `16.14%`.
> The diff coverage is `60.57%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 69.20% +16.14%
===========================================
Files 489 721 +232
Lines 17314 37305 +19991
Branches 4482 3459 -1023
===========================================
+ Hits 9187 25818 +16631
- Misses 8127 11487 +3360
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `48.10% <47.63%> (-4.96%)` | :arrow_down: |
| python | `80.63% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `85.33% <ΓΈ> (-6.67%)` | :arrow_down: |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `11.42% <0.00%> (-45.72%)` | :arrow_down: |
| [...t-frontend/src/components/DynamicPlugins/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvaW5kZXgudHN4) | `23.25% <ΓΈ> (ΓΈ)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ΓΈ> (ΓΈ)` | |
| ... and [640 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.96%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 72.02% +18.96%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28916 +19729
- Misses 8127 11230 +3103
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
| python | `80.94% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [495 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.96%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 72.02% +18.96%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28915 +19728
- Misses 8127 11231 +3104
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
| python | `80.94% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [495 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.61%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.67% +18.61%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28775 +19588
- Misses 8127 11371 +3244
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.07% <66.78%> (+5.01%)` | :arrow_up: |
| python | `80.63% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [500 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on a change in pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #13255:
URL: https://github.com/apache/superset/pull/13255#discussion_r580677039
##########
File path: superset/connectors/sqla/sql_query_utils.py
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from typing import Any, Dict
+
+
+def update_template_kwargs(
Review comment:
Is there value in pulling out this function if it's a 1-liner that runs `update` on the first dict with the second?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (9f63fea) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.77%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.83% +18.77%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28840 +19653
- Misses 8127 11306 +3179
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.42%)` | :arrow_up: |
| python | `80.63% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (d9c0a69) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.50%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.56% +18.50%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28730 +19543
- Misses 8127 11416 +3289
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
| python | `80.18% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [495 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (d9c0a69) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `5.01%`.
> The diff coverage is `66.78%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
==========================================
+ Coverage 53.06% 58.07% +5.01%
==========================================
Files 489 468 -21
Lines 17314 15942 -1372
Branches 4482 4108 -374
==========================================
+ Hits 9187 9259 +72
+ Misses 8127 6683 -1444
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.07% <66.78%> (+5.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [169 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-783872068
@mayurnewase Thank you Mayur for contribution and collaboration!π please do add more description as @ktmud suggested for project tracking and release purposes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (9f63fea) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `27.10%`.
> The diff coverage is `82.77%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 80.16% +27.10%
===========================================
Files 489 299 -190
Lines 17314 24176 +6862
Branches 4482 0 -4482
===========================================
+ Hits 9187 19380 +10193
+ Misses 8127 4796 -3331
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| python | `80.16% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ΓΈ> (ΓΈ)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.73% <ΓΈ> (ΓΈ)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.74% <4.34%> (ΓΈ)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `88.70% <16.66%> (ΓΈ)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.61% <27.27%> (ΓΈ)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <50.00%> (ΓΈ)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ΓΈ)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.28% <85.71%> (ΓΈ)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.26% <87.50%> (ΓΈ)` | |
| ... and [683 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (d9c0a69) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `5.41%`.
> The diff coverage is `66.78%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
==========================================
+ Coverage 53.06% 58.48% +5.41%
==========================================
Files 489 468 -21
Lines 17314 15942 -1372
Branches 4482 4108 -374
==========================================
+ Hits 9187 9323 +136
+ Misses 8127 6619 -1508
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [164 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (9f63fea) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.96%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 72.02% +18.96%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28917 +19730
- Misses 8127 11229 +3102
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.42%)` | :arrow_up: |
| python | `80.94% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (9f63fea) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.75%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.82% +18.75%
===========================================
Files 489 767 +278
Lines 17314 40118 +22804
Branches 4482 4108 -374
===========================================
+ Hits 9187 28813 +19626
- Misses 8127 11305 +3178
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.42%)` | :arrow_up: |
| python | `80.61% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-783872068
@mayurnewase Thank you Mayur for contribution and collaboration!π please do add more description as @ktmud suggested for project tracking and release purposes.
@villebro @willbarrett I added `hold` until description is added. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13255:
URL: https://github.com/apache/superset/pull/13255#discussion_r580009154
##########
File path: superset/connectors/sqla/models.py
##########
@@ -900,20 +924,40 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
order_desc: bool = True,
) -> SqlaQuery:
"""Querying any sqla table from this common interface"""
- template_kwargs = {
- "from_dttm": from_dttm.isoformat() if from_dttm else None,
- "groupby": groupby,
- "metrics": metrics,
- "row_limit": row_limit,
- "row_offset": row_offset,
- "to_dttm": to_dttm.isoformat() if to_dttm else None,
- "filter": filter,
- "columns": [col.column_name for col in self.columns],
- }
- template_kwargs.update(self.template_params_dict)
+
extra_cache_keys: List[Any] = []
- template_kwargs["extra_cache_keys"] = extra_cache_keys
+ is_sip_38 = is_feature_enabled("SIP_38_VIZ_REARCHITECTURE")
Review comment:
This feature flag has been removed a while ago, so you probably need to double check that all changes here are still relevant.
##########
File path: superset/connectors/sqla/models.py
##########
@@ -877,6 +878,29 @@ def _get_sqla_row_level_filters(
_("Error in jinja expression in RLS filters: %(msg)s", msg=ex.message,)
)
+ def _get_template_kwargs( # pylint:disable = too-many-arguments
+ self,
+ metrics: List[Metric],
+ extra_cache_keys: List[Any],
+ filter_: Optional[List[Dict[str, Any]]] = None,
+ from_dttm: Optional[datetime] = None,
+ to_dttm: Optional[datetime] = None,
+ groupby: Optional[List[str]] = None,
+ row_limit: Optional[int] = None,
+ row_offset: Optional[int] = None,
+ ) -> Dict[str, Any]:
+ return {
+ "from_dttm": from_dttm.isoformat() if from_dttm else None,
+ "groupby": groupby,
+ "metrics": metrics,
+ "row_limit": row_limit,
+ "row_offset": row_offset,
+ "to_dttm": to_dttm.isoformat() if to_dttm else None,
+ "filter": filter_,
+ "columns": [col.column_name for col in self.columns],
+ "extra_cache_keys": extra_cache_keys,
+ }
+
Review comment:
Would it make sense to combine `_get_template_kwargs` and `update_template_kwargs` into one function in `sql_query_utils.py`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `27.10%`.
> The diff coverage is `82.77%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 80.16% +27.10%
===========================================
Files 489 299 -190
Lines 17314 24176 +6862
Branches 4482 0 -4482
===========================================
+ Hits 9187 19380 +10193
+ Misses 8127 4796 -3331
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| python | `80.16% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ΓΈ> (ΓΈ)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.73% <ΓΈ> (ΓΈ)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.74% <4.34%> (ΓΈ)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `88.70% <16.66%> (ΓΈ)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.61% <27.27%> (ΓΈ)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <50.00%> (ΓΈ)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ΓΈ)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.28% <85.71%> (ΓΈ)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.26% <87.50%> (ΓΈ)` | |
| ... and [683 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-792256798
> Sorry, hit Approve by mistake.
>
> I think we need to think deeper on how to structure the SQL query generator in an extensible and maintainable way. There's nothing wrong with splitting things into various smaller functions, but considering how many variables we need to manipulate and manage, a `QueryBuilder` class might make more sense. There's definitely room for util functions, but it is better to make sure they only accept a couple of arguments (<= 4), so we don't have to pass a lot of parameters around.
Yeah,I went through how sqlalchemy uses `Query` class to generate queries which makes it easier.
I will try to do in that fashion in future prs if required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (9f63fea) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `19.03%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 72.09% +19.03%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28944 +19757
- Misses 8127 11202 +3075
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.42%)` | :arrow_up: |
| python | `81.06% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782773322
@villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `27.57%`.
> The diff coverage is `82.77%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 80.63% +27.57%
===========================================
Files 489 299 -190
Lines 17314 24204 +6890
Branches 4482 0 -4482
===========================================
+ Hits 9187 19516 +10329
+ Misses 8127 4688 -3439
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| python | `80.63% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ΓΈ> (ΓΈ)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.73% <ΓΈ> (ΓΈ)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.43% <4.34%> (ΓΈ)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `88.70% <16.66%> (ΓΈ)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.61% <27.27%> (ΓΈ)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <50.00%> (ΓΈ)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ΓΈ)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.42% <85.71%> (ΓΈ)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.26% <87.50%> (ΓΈ)` | |
| ... and [683 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase closed pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
mayurnewase closed pull request #13255:
URL: https://github.com/apache/superset/pull/13255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13255: refactor(connectors:sqla): break sqla query generator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13255:
URL: https://github.com/apache/superset/pull/13255#issuecomment-782668647
# [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=h1) Report
> Merging [#13255](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=desc) (248ffd6) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `18.77%`.
> The diff coverage is `72.39%`.
[](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13255 +/- ##
===========================================
+ Coverage 53.06% 71.83% +18.77%
===========================================
Files 489 767 +278
Lines 17314 40146 +22832
Branches 4482 4108 -374
===========================================
+ Hits 9187 28839 +19652
- Misses 8127 11307 +3180
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `58.48% <66.78%> (+5.41%)` | :arrow_up: |
| python | `80.63% <82.77%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.16% <0.00%> (-0.09%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ΓΈ> (ΓΈ)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ΓΈ> (ΓΈ)` | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ΓΈ> (ΓΈ)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
| ... and [495 more](https://codecov.io/gh/apache/superset/pull/13255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=footer). Last update [786c12d...248ffd6](https://codecov.io/gh/apache/superset/pull/13255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org