You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:43:48 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #6912: [HUDI-3900] Fixing hdfs setup and tear down in tests to avoid flakiness

xushiyan commented on code in PR #6912:
URL: https://github.com/apache/hudi/pull/6912#discussion_r994416683


##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -144,6 +144,7 @@ public void setUp() throws IOException, InterruptedException {
   @AfterEach
   public void tearDown() throws IOException {
     fs.delete(partitionPath, true);
+    fs.delete(new Path(basePath), true);

Review Comment:
   this is not necessary as `tempDir` is annotated with `org.junit.jupiter.api.io.TempDir;` which will be cleaned up automatically



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org