You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hertzbeat.apache.org by "Duansg (via GitHub)" <gi...@apache.org> on 2026/03/01 14:33:13 UTC
[PR] [improve] add group convergence strategy name validation [hertzbeat]
Duansg opened a new pull request, #4050:
URL: https://github.com/apache/hertzbeat/pull/4050
## What's changed?
> This PR addresses potential issues currently present in group convergence.
1. Display of empty tags in the current grouping convergence strategy; once saved successfully, they can also participate in the determination.
<img width="1111" height="349" alt="Snipaste_2026-02-27_19-00-50" src="https://github.com/user-attachments/assets/09adf9f4-12b5-4126-80f5-52a9f5346f26" />
```
// verification code
private boolean hasRequiredLabels(Map<String, String> labels, List<String> requiredLabels) {
return requiredLabels.stream().allMatch(labels::containsKey);
}
```
2. Input prompts and restriction information overlap.
<img width="1021" height="318" alt="Snipaste_2026-02-27_19-09-43" src="https://github.com/user-attachments/assets/77be01a5-a321-4ee1-bff5-2074c4aeae60" />
3. Multiple strategies save invalidation issue.
```
// Store using the policy name as the key
public void refreshGroupDefines(List<AlertGroupConverge> groupDefines) {
this.groupDefines.clear();
groupDefines.forEach(define -> this.groupDefines.put(define.getName(), define));
}
```
4. Styling issue with excessively long `Group Labels`
<img width="917" height="305" alt="Snipaste_2026-02-27_22-45-51" src="https://github.com/user-attachments/assets/31fc0969-169c-43b1-be1a-6414d220f1d4" />
## Modification details
- [x] Optimize the display and validation of empty tags.
- [x] Simplify input prompts to prevent style conflicts.
- [x] Optimize the display style of tags on list pages.
- [x] Added test cases and passed successfully.
## Checklist
- [x] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
- [ ] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
## Add or update API
- [ ] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [PR] [improve] add group convergence strategy name validation [hertzbeat]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 merged PR #4050:
URL: https://github.com/apache/hertzbeat/pull/4050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org