You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/23 14:03:26 UTC

[GitHub] [flink] libenchao commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner

libenchao commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-590071970
 
 
   One small question not related to the code.
   
   Do we have any consensus about the review process in the community. I'm asking because I see you have squashed your commits and force pushed to your current branch.
   In my practice, usually I prefer keeping the commits during whole review process and not forcing push. So the reviewers can check only incremental changes next time which will save a lot of time. And Github itself can do the squash for us.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services