You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/12/25 07:45:11 UTC

[GitHub] [servicecomb-java-chassis] GuoYL123 opened a new pull request #1490: [SCB-1407] router add spi config file/add to dependencies

GuoYL123 opened a new pull request #1490: [SCB-1407] router add spi config file/add to dependencies
URL: https://github.com/apache/servicecomb-java-chassis/pull/1490
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1490: [SCB-1407] router add spi config file/add to dependencies

Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #1490: [SCB-1407] router add spi config file/add to dependencies
URL: https://github.com/apache/servicecomb-java-chassis/pull/1490#discussion_r361404864
 
 

 ##########
 File path: java-chassis-dependencies/default/pom.xml
 ##########
 @@ -1121,6 +1121,11 @@
         <artifactId>handler-bizkeeper</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <dependency>
 
 Review comment:
   add to java-chassis-distribution & solution-basic & coverage-reports

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1490: [SCB-1407] router add spi config file/add to dependencies

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1490: [SCB-1407] router add spi config file/add to dependencies
URL: https://github.com/apache/servicecomb-java-chassis/pull/1490
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1490: [SCB-1407] router add spi config file/add to dependencies

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1490: [SCB-1407] router add spi config file/add to dependencies
URL: https://github.com/apache/servicecomb-java-chassis/pull/1490#issuecomment-568862067
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27796016/badge)](https://coveralls.io/builds/27796016)
   
   Coverage decreased (-0.006%) to 84.027% when pulling **40ff0c32108ce34e726cc95d73a96714e81c289a on GuoYL123:master** into **e3647646032852c10eb0b5b88c492b87ccc381c1 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1490: [SCB-1407] router add spi config file/add to dependencies

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1490: [SCB-1407] router add spi config file/add to dependencies
URL: https://github.com/apache/servicecomb-java-chassis/pull/1490#discussion_r361288412
 
 

 ##########
 File path: java-chassis-dependencies/default/pom.xml
 ##########
 @@ -1121,6 +1121,11 @@
         <artifactId>handler-bizkeeper</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <dependency>
 
 Review comment:
   better add java-chassis-distribution along

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1490: [SCB-1407] router add spi config file/add to dependencies

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1490: [SCB-1407] router add spi config file/add to dependencies
URL: https://github.com/apache/servicecomb-java-chassis/pull/1490#issuecomment-568862067
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27787920/badge)](https://coveralls.io/builds/27787920)
   
   Coverage increased (+0.009%) to 83.897% when pulling **1d6e72884f28e99d2955185887134f821735f7d8 on GuoYL123:master** into **27fb552e835df2fe7dfb6759ddc9fa4f0be7fb7e on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services