You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/08/02 20:13:35 UTC

[I] license issue: caniuse-lite has an license that is NOT approved for use in ASF projects [cordova-common]

pjfanning opened a new issue, #209:
URL: https://github.com/apache/cordova-common/issues/209

   See https://github.com/apache/cordova-common/blob/master/NOTICE
   
   The CC-BY-4.0 license is Category X and incompatible with Apache Software License.
   
   https://www.apache.org/legal/resolved.html#cc-by
   
   Please remove the dependency and update your LICENSE/NOTICE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has a license that is NOT approved for use in ASF projects [cordova-common]

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on issue #209:
URL: https://github.com/apache/cordova-common/issues/209#issuecomment-2266099901

   We can definitely update the NOTICE file.
   
   Do you know if there's clear ASF documentation about when dependencies need to be listed or not? We've been erring on the side of caution by listing everything we use, even if it's only for development use.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has an license that is NOT approved for use in ASF projects [cordova-common]

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on issue #209:
URL: https://github.com/apache/cordova-common/issues/209#issuecomment-2266086917

   For context, `caniuse-lite` is a subdependency several layers down of the JavaScript code coverage reporting tool `nyc`, which is only used as a [development dependency](https://github.com/apache/cordova-common/blob/3d7f7360273b90c73d263f2fa42eaf0daca453ad/package.json#L37) and is not distributed by, included by, or installed by end users of Cordova.
   
   ```
   $ npm ls caniuse-lite
   
   cordova-common@5.0.1-dev
   └─┬ nyc@15.1.0
     └─┬ istanbul-lib-instrument@4.0.3
       └─┬ @babel/core@7.24.3
         └─┬ @babel/helper-compilation-targets@7.23.6
           └─┬ browserslist@4.23.0
             └── caniuse-lite@1.0.30001600
   ```
   
   I don't believe it's possible to drop this without dropping code coverage for unit testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has a license that is NOT approved for use in ASF projects [cordova-common]

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue closed issue #209: license issue: caniuse-lite has a license that is NOT approved for use in ASF projects
URL: https://github.com/apache/cordova-common/issues/209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has a license that is NOT approved for use in ASF projects [cordova-common]

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue closed issue #209: license issue: caniuse-lite has a license that is NOT approved for use in ASF projects
URL: https://github.com/apache/cordova-common/issues/209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has a license that is NOT approved for use in ASF projects [cordova-common]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #209:
URL: https://github.com/apache/cordova-common/issues/209#issuecomment-2266107200

   The LICENSE file is where you list licenses for 3rd party source code that you include in your source releases.
   The NOTICE file is where you list notices for 3rd party source code that you include in your source releases.
   
   If you release binary artifacts too, then they should have LICENSE and NOTICE files that reflect what is in those binary artifacts.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has an license that is NOT approved for use in ASF projects [cordova-common]

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on issue #209:
URL: https://github.com/apache/cordova-common/issues/209#issuecomment-2266090543

   Looks like it's being imported via `nyc` package:
   
   ```
   npm ls caniuse-lite
   cordova-common@5.0.1-dev /development/cordova/apache/cordova-common
   └─┬ nyc@15.1.0
     └─┬ istanbul-lib-instrument@4.0.3
       └─┬ @babel/core@7.24.3
         └─┬ @babel/helper-compilation-targets@7.23.6
           └─┬ browserslist@4.23.0
             └── caniuse-lite@1.0.30001600
   ```
   
   I tried updating to the latest version of nyc but it still has the dependency:
   
   ```
   npm ls caniuse-lite
   cordova-common@5.0.1-dev /development/cordova/apache/cordova-common
   └─┬ nyc@17.0.0
     └─┬ istanbul-lib-instrument@6.0.3
       └─┬ @babel/core@7.25.2
         └─┬ @babel/helper-compilation-targets@7.25.2
           └─┬ browserslist@4.23.3
             └── caniuse-lite@1.0.30001646
   
   ```
   
   So that means we will have to drop nyc (a code coverage tool) :\
   
   > Issue also seems to affact https://github.com/apache/cordova-eslint
   
   It likely affects all cordova packages tbh, `nyc` is a widely used package.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [I] license issue: caniuse-lite has an license that is NOT approved for use in ASF projects [cordova-common]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #209:
URL: https://github.com/apache/cordova-common/issues/209#issuecomment-2266095024

   Could you at least update the NOTICE files? If you do not ship the source code of caniuse-lite then you don't need to mention it in your LICENSE or NOTICE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org