You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/05/11 16:14:11 UTC
[PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests [incubator-uniffle]
rickyma opened a new pull request, #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696
### What changes were proposed in this pull request?
Fix some flaky tests which may cause port conflicts sometimes.
### Why are the changes needed?
Fix: https://github.com/apache/incubator-uniffle/issues/1675.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696#issuecomment-2111770922
> Maybe we should commit this to branch 0.9, too.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696#issuecomment-2109589528
LGTM. Please update the PR title to describe what's this PR changed rather than coarse grained desp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696#issuecomment-2109888880
Maybe we should commit this to branch 0.9, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696#issuecomment-2105947046
## Test Results
2 212 files - 179 2 212 suites - 179 3h 25m 13s :stopwatch: - 1h 31m 37s
875 tests - 53 874 :white_check_mark: - 53 1 :zzz: ±0 0 :x: ±0
10 309 runs - 445 10 295 :white_check_mark: - 445 14 :zzz: ±0 0 :x: ±0
Results for commit a0052fcb. ± Comparison against base commit 8e26a34e.
<details>
<summary>This pull request <b>removes</b> 53 tests.</summary>
```
org.apache.uniffle.test.AQERepartitionTest ‑ resultCompareTest
org.apache.uniffle.test.AQESkewedJoinTest ‑ resultCompareTest
org.apache.uniffle.test.AQESkewedJoinWithLocalOrderTest ‑ resultCompareTest
org.apache.uniffle.test.AutoAccessTest ‑ test
org.apache.uniffle.test.CombineByKeyTest ‑ combineByKeyTest
org.apache.uniffle.test.ContinuousSelectPartitionStrategyTest ‑ resultCompareTest
org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest
org.apache.uniffle.test.GetReaderTest ‑ test
org.apache.uniffle.test.GetShuffleReportForMultiPartTest ‑ resultCompareTest
org.apache.uniffle.test.GroupByKeyTest ‑ groupByTest
…
```
</details>
[test-results]:data:application/gzip;base64,H4sIAI2cP2YC/03MTQ6DIBCG4asY1l0MMFjtZRoYmYTUnwZh1fTuRSPW5fcwvB/BYfSreDRKSXVrxJpDuu4hR5vCMheRSktdqLyn7aK7m7qeaybaCf/0Cu/t1wlsw1gATvAxLvGQmOetKUFDf8walaB6c9pRxQqX6r6vUVqmKaQyhAUwiskZ7HlwrdUe2o65JXToJHmNpB0yiO8PdEjhhhIBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma closed pull request #1696: [#1675][FOLLOWUP] fix(test): Fix flaky tests
URL: https://github.com/apache/incubator-uniffle/pull/1696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix flaky tests [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1696:
URL: https://github.com/apache/incubator-uniffle/pull/1696#issuecomment-2109567443
This could be merged. Minor fixes. More stable for the test. It forgot to stop the server, which might cause port conflicts. @zuston @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org