[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #314: HDDS-2555. Handle InterruptedException in XceiverClientGrpc

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #314: HDDS-2555. Handle InterruptedException in XceiverClientGrpc
URL: https://github.com/apache/hadoop-ozone/pull/314#discussion_r357882464
 
 

 ##########
 File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
 ##########
 @@ -244,8 +248,12 @@ public ContainerCommandResponseProto sendCommand(
       XceiverClientReply reply;
       reply = sendCommandWithTraceIDAndRetry(request, validators);
       return reply.getResponse().get();
-    } catch (ExecutionException | InterruptedException e) {
+    } catch (ExecutionException e) {
       throw new IOException("Failed to execute command " + request, e);
+    } catch (InterruptedException e) {
 
 Review comment:
   Now when Interrupted Exception happens, we return null. But I see in some places callers do not have a check for not null.
   
   For instance
   **ContainerProtocolCalls.java L 117:**
   ```
       ContainerCommandResponseProto response =
           xceiverClient.sendCommand(request, getValidatorList());
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org