You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Anton Vinogradov <av...@gridgain.com> on 2015/12/01 08:48:00 UTC
Re: OSGi integration ready for review
Raul,
I've added 1.6 space as a copy of 1.5.
But I gain no results at OSGi search.
Could you please specify what pages should be removed from 1.5 or revome
them by yourself?
On Mon, Nov 30, 2015 at 6:18 PM, Yakov Zhdanov <yz...@apache.org> wrote:
> Raul, as far as commits - they are mostly fixes for functionality, but do
> not add new features.
>
> Can someone create 1.6 space and move OSGi articles there? Perhaps, Anton
> V. can do it?
>
> --Yakov
>
> 2015-11-30 16:42 GMT+03:00 Raul Kripalani <ra...@apache.org>:
>
> > Dmitriy,
> >
> > I'm not going to judge if the communication of release timelines is
> > efficient. In fact, the release has still not been made and there's no
> > traffic in the ML about what's going on. Commits are still being pushed,
> no
> > one knows anything. It seems communication is internal between
> committers.
> > But anyway, let's move ahead with OSGi.
> >
> > I have merged 1.5 into master, and master into ignite-1270. So it's now
> > mergeable into 1.6
> >
> > Someone needs to remove OSGi from the readme.io and push it into 1.6
> (not
> > me, I'm not happy with all this).
> >
> > Regards,
> >
> > *Raúl Kripalani*
> > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
> > Messaging Engineer
> > http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
> > http://blog.raulkr.net | twitter: @raulvk
> >
> > On Sat, Nov 28, 2015 at 5:13 AM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > wrote:
> >
> > > On Fri, Nov 27, 2015 at 5:48 PM, Raul Kripalani <ra...@apache.org>
> > wrote:
> > >
> > > > Aside from Dmitriy's questions, was there any blocker for someone to
> > > review
> > > > the code? There has been no activity from committers.
> > > >
> > >
> > > As I mentioned last week, we were planning to cut a release this
> Friday,
> > > but I don’t think it happened. I too would like to get an update.
> Yakov,
> > > can you send out the status on open issues?
> > >
> > >
> > > > It was supposed to be merged for 1.5, and as far as I know, there was
> > no
> > > > official announcement in the dev@ list that the release was being
> cut
> > > > today. How is the dev team supposed to be synchronised around these
> > > > milestones???
> > > >
> > >
> > > Raul, I am hoping the release will happen over the weekend, assuming we
> > get
> > > an update. Even in that case, forcefully merging a new feature, that is
> > not
> > > a critical bug fix, at this point would be too risky.
> > >
> > > My preference would be to cut another release with OSGI, Cammel, and
> > > Node.JS early January (no point of doing it sooner due to holidays).
> > Would
> > > do you think?
> > >
> > >
> > > >
> > > > To the release manager: please take out the OSGi documentation from
> 1.5
> > > in
> > > > readme.io and put it in 1.6.
> > > >
> > > > Regards,
> > > >
> > > > *Raúl Kripalani*
> > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data
> > and
> > > > Messaging Engineer
> > > > http://about.me/raulkripalani |
> > http://www.linkedin.com/in/raulkripalani
> > > > http://blog.raulkr.net | twitter: @raulvk
> > > >
> > > > On Tue, Nov 24, 2015 at 8:11 PM, Raul Kripalani <ra...@apache.org>
> > > wrote:
> > > >
> > > > > Hello all,
> > > > >
> > > > > The initial OSGi integration is ready for review in branch
> > ignite-1270.
> > > > > Features included:
> > > > >
> > > > > * OSGi manifest for most modules. I could OSGi-fy 22 modules. Some
> > are
> > > > > left out due to complexity or not supporting OSGi: hadoop, mesos,
> > > cloud,
> > > > > gce, yarn, etc.
> > > > > * Karaf features repository with 1 feature per module + a global
> > > > > ignite-all feature. Each feature installs the required dependencies
> > > into
> > > > > the container.
> > > > > * Ignite OSGi Bundle Activator which activates an Ignite OSGi
> > > > > configuration and injects the appropriate OSGi-friendly
> classloader.
> > > > > * Two classloading strategies for OSGi:
> > > > > * Bundle Delegating => attempts to find the class in the bundle
> > > that
> > > > > loaded Ignite, falling back to ignite-core.
> > > > > * Container Sweep => same as above, but sweeps the entire OSGi
> > > > > container for the first hit as the ultimate fallback (keeps a
> cache).
> > > > >
> > > > > (@Romain – the latter should work for you).
> > > > >
> > > > > Since generating the Karaf features repo (features.xml) requires
> > > > including
> > > > > version numbers of the 3rd party deps, I have promoted the version
> > > > numbers
> > > > > I needed to parent/pom.xml as Maven properties. This is also a
> Maven
> > > best
> > > > > practice.
> > > > >
> > > > > In this branch, IGNITE-1810 is also included. I was able to test it
> > > > > locally only, given that the CI test job is broken in TeamCity.
> > > > >
> > > > > Note: Spring configuration of Ignite is not supported due to Spring
> > DM
> > > > > 1.2.1 not being compatible with Spring Framework 4.x anymore. This
> is
> > > > being
> > > > > discussed at the SMX community [1]. For now, we only support
> > > programmatic
> > > > > configuration.
> > > > >
> > > > > As you know, I created a user guide section for OSGi in the 1.5
> docs
> > > [2].
> > > > >
> > > > > I'd like this feature to target 1.5. It does modify existing Ignite
> > > > > codebase, so it should be pretty safe to release.
> > > > >
> > > > > [1]
> > > > >
> > > >
> > >
> >
> http://servicemix.396122.n5.nabble.com/Spring-DM-for-Spring-4-in-SMX-Karaf-td5723130.html
> > > > > [2] https://dash.readme.io/project/apacheignite/v1.5
> > > > >
> > > > > *Raúl Kripalani*
> > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big
> Data
> > > and
> > > > > Messaging Engineer
> > > > > http://about.me/raulkripalani |
> > > http://www.linkedin.com/in/raulkripalani
> > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > >
> > > >
> > >
> >
>
Re: OSGi integration ready for review
Posted by Raul Kripalani <ra...@apache.org>.
On Thu, Dec 3, 2015 at 9:20 AM, Romain Gilles <ro...@gmail.com>
wrote:
> Some times maven-bundle-plugin can have side effect on
> split package but I hope Raul has already checked it.
>
Not sure which side effect you mean. But anyway, the maven-bundle-plugin
has several goals. There is a goal to delegate packaging to the plugin by
using the "bundle" packaging, but I have not used that.
We just invoke the manifest goal of the plugin to generate the MANIFEST.MF,
and then we package the manifest into the JAR.
The only things I mention to Raul is to double check that the user class
> loader (here Raul provide an OSGi aware user classloader) is used every
> where in the serialization process:
> - Binary marshaller (new)
> - Optimized marshaller (old)
Correct. It was my reading of the source code that the user-set classloader
(Ignite#setClassLoader) was not used in some cases (IGNITE-1930). But
during my tests where I used the default marshaller with 1.5.0 (Binary
Marshaller – Romain sorry for the confusion in Skype), I faced no issues
for basic use cases. However, creating unit tests for OSGi is not a simple
task and that's why I'd like to release this out to the public, so that
everyone who's interested in OSGi can give it a spin with their use cases.
As I said in IGNITE-1930, the usage of classloaders inside Ignite is choppy
and should be improved to ensure that the user-set classloader is always
used if set.
We can declare OSGi functionality as "preview" – that would make me, and
probably others, comfortable.
Regards,
*Raúl Kripalani*
PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
Messaging Engineer
http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
http://blog.raulkr.net | twitter: @raulvk
Re: OSGi integration ready for review
Posted by Yakov Zhdanov <yz...@apache.org>.
Raul, I did review as well. I added my comments to the ticket and committed
some changes to ignite-1270.
Given that this feature is desperately desired, can we merge it to 1.5? To
do that you can squash all the differences between 1270 and master and pick
that commit to ignite-1.5. If someone knows better way to do this, please
let us know.
I think 1.5-final can be released in 2 weeks, i.e. around Dec, 18.
--Yakov
2015-12-03 12:20 GMT+03:00 Romain Gilles <ro...@gmail.com>:
> Hi Igniters,
> I did the review. I term of impact the Raul commits change the manifest of
> the overall produced jar files to introduce OSGi specific headers. This
> will not impact original ignite usage as OSGi headers does are only for
> OSGi environments. Some times maven-bundle-plugin can have side effect on
> split package but I hope Raul has already checked it.
> Then in term of code Raul has only added new project and code. He didn't
> modify a single line of code in the already existing project therefore it
> should not impact the existing code has it didn't touch it.
> The only things I mention to Raul is to double check that the user class
> loader (here Raul provide an OSGi aware user classloader) is used every
> where in the serialization process:
> - Binary marshaller (new)
> - Optimized marshaller (old)
> But here again it is just to make sure that in OSGi environment the new
> feature provided by Raul will work without bad surprise it doesn't impact
> the existing code.
>
>
> Other than that it is a great feature and I'm excited to be able to use it!
>
> Romain.
>
> PS: some enhancement will be added in the future as discussed in the jira
> ticket during the review. But it is an iterative approach and for now what
> is provide is enough to start!
>
> Le jeu. 3 déc. 2015 à 02:43, Dmitriy Setrakyan <ds...@apache.org> a
> écrit :
>
> > Guys,
> >
> > Should we try to review and merge the OSGI integration before the final
> > release? it does sound like it is additive and should not affect other
> > functionality.
> >
> > My preference would be to get it in, so other OSGI-related integrations
> > (e.g. Camel) would not have to wait for 1.6.
> >
> > Thoughts?
> > D.
> >
> > On Mon, Nov 30, 2015 at 11:48 PM, Anton Vinogradov <
> > avinogradov@gridgain.com
> > > wrote:
> >
> > > Raul,
> > >
> > > I've added 1.6 space as a copy of 1.5.
> > > But I gain no results at OSGi search.
> > > Could you please specify what pages should be removed from 1.5 or
> revome
> > > them by yourself?
> > >
> > > On Mon, Nov 30, 2015 at 6:18 PM, Yakov Zhdanov <yz...@apache.org>
> > > wrote:
> > >
> > > > Raul, as far as commits - they are mostly fixes for functionality,
> but
> > do
> > > > not add new features.
> > > >
> > > > Can someone create 1.6 space and move OSGi articles there? Perhaps,
> > Anton
> > > > V. can do it?
> > > >
> > > > --Yakov
> > > >
> > > > 2015-11-30 16:42 GMT+03:00 Raul Kripalani <ra...@apache.org>:
> > > >
> > > > > Dmitriy,
> > > > >
> > > > > I'm not going to judge if the communication of release timelines is
> > > > > efficient. In fact, the release has still not been made and there's
> > no
> > > > > traffic in the ML about what's going on. Commits are still being
> > > pushed,
> > > > no
> > > > > one knows anything. It seems communication is internal between
> > > > committers.
> > > > > But anyway, let's move ahead with OSGi.
> > > > >
> > > > > I have merged 1.5 into master, and master into ignite-1270. So it's
> > now
> > > > > mergeable into 1.6
> > > > >
> > > > > Someone needs to remove OSGi from the readme.io and push it into
> 1.6
> > > > (not
> > > > > me, I'm not happy with all this).
> > > > >
> > > > > Regards,
> > > > >
> > > > > *Raúl Kripalani*
> > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big
> Data
> > > and
> > > > > Messaging Engineer
> > > > > http://about.me/raulkripalani |
> > > http://www.linkedin.com/in/raulkripalani
> > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > >
> > > > > On Sat, Nov 28, 2015 at 5:13 AM, Dmitriy Setrakyan <
> > > > dsetrakyan@apache.org>
> > > > > wrote:
> > > > >
> > > > > > On Fri, Nov 27, 2015 at 5:48 PM, Raul Kripalani <
> raulk@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > > Aside from Dmitriy's questions, was there any blocker for
> someone
> > > to
> > > > > > review
> > > > > > > the code? There has been no activity from committers.
> > > > > > >
> > > > > >
> > > > > > As I mentioned last week, we were planning to cut a release this
> > > > Friday,
> > > > > > but I don’t think it happened. I too would like to get an update.
> > > > Yakov,
> > > > > > can you send out the status on open issues?
> > > > > >
> > > > > >
> > > > > > > It was supposed to be merged for 1.5, and as far as I know,
> there
> > > was
> > > > > no
> > > > > > > official announcement in the dev@ list that the release was
> > being
> > > > cut
> > > > > > > today. How is the dev team supposed to be synchronised around
> > these
> > > > > > > milestones???
> > > > > > >
> > > > > >
> > > > > > Raul, I am hoping the release will happen over the weekend,
> > assuming
> > > we
> > > > > get
> > > > > > an update. Even in that case, forcefully merging a new feature,
> > that
> > > is
> > > > > not
> > > > > > a critical bug fix, at this point would be too risky.
> > > > > >
> > > > > > My preference would be to cut another release with OSGI, Cammel,
> > and
> > > > > > Node.JS early January (no point of doing it sooner due to
> > holidays).
> > > > > Would
> > > > > > do you think?
> > > > > >
> > > > > >
> > > > > > >
> > > > > > > To the release manager: please take out the OSGi documentation
> > from
> > > > 1.5
> > > > > > in
> > > > > > > readme.io and put it in 1.6.
> > > > > > >
> > > > > > > Regards,
> > > > > > >
> > > > > > > *Raúl Kripalani*
> > > > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration,
> Big
> > > Data
> > > > > and
> > > > > > > Messaging Engineer
> > > > > > > http://about.me/raulkripalani |
> > > > > http://www.linkedin.com/in/raulkripalani
> > > > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > > > >
> > > > > > > On Tue, Nov 24, 2015 at 8:11 PM, Raul Kripalani <
> > raulk@apache.org>
> > > > > > wrote:
> > > > > > >
> > > > > > > > Hello all,
> > > > > > > >
> > > > > > > > The initial OSGi integration is ready for review in branch
> > > > > ignite-1270.
> > > > > > > > Features included:
> > > > > > > >
> > > > > > > > * OSGi manifest for most modules. I could OSGi-fy 22 modules.
> > > Some
> > > > > are
> > > > > > > > left out due to complexity or not supporting OSGi: hadoop,
> > mesos,
> > > > > > cloud,
> > > > > > > > gce, yarn, etc.
> > > > > > > > * Karaf features repository with 1 feature per module + a
> > global
> > > > > > > > ignite-all feature. Each feature installs the required
> > > dependencies
> > > > > > into
> > > > > > > > the container.
> > > > > > > > * Ignite OSGi Bundle Activator which activates an Ignite OSGi
> > > > > > > > configuration and injects the appropriate OSGi-friendly
> > > > classloader.
> > > > > > > > * Two classloading strategies for OSGi:
> > > > > > > > * Bundle Delegating => attempts to find the class in the
> > > bundle
> > > > > > that
> > > > > > > > loaded Ignite, falling back to ignite-core.
> > > > > > > > * Container Sweep => same as above, but sweeps the entire
> > > OSGi
> > > > > > > > container for the first hit as the ultimate fallback (keeps a
> > > > cache).
> > > > > > > >
> > > > > > > > (@Romain – the latter should work for you).
> > > > > > > >
> > > > > > > > Since generating the Karaf features repo (features.xml)
> > requires
> > > > > > > including
> > > > > > > > version numbers of the 3rd party deps, I have promoted the
> > > version
> > > > > > > numbers
> > > > > > > > I needed to parent/pom.xml as Maven properties. This is also
> a
> > > > Maven
> > > > > > best
> > > > > > > > practice.
> > > > > > > >
> > > > > > > > In this branch, IGNITE-1810 is also included. I was able to
> > test
> > > it
> > > > > > > > locally only, given that the CI test job is broken in
> TeamCity.
> > > > > > > >
> > > > > > > > Note: Spring configuration of Ignite is not supported due to
> > > Spring
> > > > > DM
> > > > > > > > 1.2.1 not being compatible with Spring Framework 4.x anymore.
> > > This
> > > > is
> > > > > > > being
> > > > > > > > discussed at the SMX community [1]. For now, we only support
> > > > > > programmatic
> > > > > > > > configuration.
> > > > > > > >
> > > > > > > > As you know, I created a user guide section for OSGi in the
> 1.5
> > > > docs
> > > > > > [2].
> > > > > > > >
> > > > > > > > I'd like this feature to target 1.5. It does modify existing
> > > Ignite
> > > > > > > > codebase, so it should be pretty safe to release.
> > > > > > > >
> > > > > > > > [1]
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> http://servicemix.396122.n5.nabble.com/Spring-DM-for-Spring-4-in-SMX-Karaf-td5723130.html
> > > > > > > > [2] https://dash.readme.io/project/apacheignite/v1.5
> > > > > > > >
> > > > > > > > *Raúl Kripalani*
> > > > > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration,
> > Big
> > > > Data
> > > > > > and
> > > > > > > > Messaging Engineer
> > > > > > > > http://about.me/raulkripalani |
> > > > > > http://www.linkedin.com/in/raulkripalani
> > > > > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: OSGi integration ready for review
Posted by Romain Gilles <ro...@gmail.com>.
Hi Igniters,
I did the review. I term of impact the Raul commits change the manifest of
the overall produced jar files to introduce OSGi specific headers. This
will not impact original ignite usage as OSGi headers does are only for
OSGi environments. Some times maven-bundle-plugin can have side effect on
split package but I hope Raul has already checked it.
Then in term of code Raul has only added new project and code. He didn't
modify a single line of code in the already existing project therefore it
should not impact the existing code has it didn't touch it.
The only things I mention to Raul is to double check that the user class
loader (here Raul provide an OSGi aware user classloader) is used every
where in the serialization process:
- Binary marshaller (new)
- Optimized marshaller (old)
But here again it is just to make sure that in OSGi environment the new
feature provided by Raul will work without bad surprise it doesn't impact
the existing code.
Other than that it is a great feature and I'm excited to be able to use it!
Romain.
PS: some enhancement will be added in the future as discussed in the jira
ticket during the review. But it is an iterative approach and for now what
is provide is enough to start!
Le jeu. 3 déc. 2015 à 02:43, Dmitriy Setrakyan <ds...@apache.org> a
écrit :
> Guys,
>
> Should we try to review and merge the OSGI integration before the final
> release? it does sound like it is additive and should not affect other
> functionality.
>
> My preference would be to get it in, so other OSGI-related integrations
> (e.g. Camel) would not have to wait for 1.6.
>
> Thoughts?
> D.
>
> On Mon, Nov 30, 2015 at 11:48 PM, Anton Vinogradov <
> avinogradov@gridgain.com
> > wrote:
>
> > Raul,
> >
> > I've added 1.6 space as a copy of 1.5.
> > But I gain no results at OSGi search.
> > Could you please specify what pages should be removed from 1.5 or revome
> > them by yourself?
> >
> > On Mon, Nov 30, 2015 at 6:18 PM, Yakov Zhdanov <yz...@apache.org>
> > wrote:
> >
> > > Raul, as far as commits - they are mostly fixes for functionality, but
> do
> > > not add new features.
> > >
> > > Can someone create 1.6 space and move OSGi articles there? Perhaps,
> Anton
> > > V. can do it?
> > >
> > > --Yakov
> > >
> > > 2015-11-30 16:42 GMT+03:00 Raul Kripalani <ra...@apache.org>:
> > >
> > > > Dmitriy,
> > > >
> > > > I'm not going to judge if the communication of release timelines is
> > > > efficient. In fact, the release has still not been made and there's
> no
> > > > traffic in the ML about what's going on. Commits are still being
> > pushed,
> > > no
> > > > one knows anything. It seems communication is internal between
> > > committers.
> > > > But anyway, let's move ahead with OSGi.
> > > >
> > > > I have merged 1.5 into master, and master into ignite-1270. So it's
> now
> > > > mergeable into 1.6
> > > >
> > > > Someone needs to remove OSGi from the readme.io and push it into 1.6
> > > (not
> > > > me, I'm not happy with all this).
> > > >
> > > > Regards,
> > > >
> > > > *Raúl Kripalani*
> > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data
> > and
> > > > Messaging Engineer
> > > > http://about.me/raulkripalani |
> > http://www.linkedin.com/in/raulkripalani
> > > > http://blog.raulkr.net | twitter: @raulvk
> > > >
> > > > On Sat, Nov 28, 2015 at 5:13 AM, Dmitriy Setrakyan <
> > > dsetrakyan@apache.org>
> > > > wrote:
> > > >
> > > > > On Fri, Nov 27, 2015 at 5:48 PM, Raul Kripalani <ra...@apache.org>
> > > > wrote:
> > > > >
> > > > > > Aside from Dmitriy's questions, was there any blocker for someone
> > to
> > > > > review
> > > > > > the code? There has been no activity from committers.
> > > > > >
> > > > >
> > > > > As I mentioned last week, we were planning to cut a release this
> > > Friday,
> > > > > but I don’t think it happened. I too would like to get an update.
> > > Yakov,
> > > > > can you send out the status on open issues?
> > > > >
> > > > >
> > > > > > It was supposed to be merged for 1.5, and as far as I know, there
> > was
> > > > no
> > > > > > official announcement in the dev@ list that the release was
> being
> > > cut
> > > > > > today. How is the dev team supposed to be synchronised around
> these
> > > > > > milestones???
> > > > > >
> > > > >
> > > > > Raul, I am hoping the release will happen over the weekend,
> assuming
> > we
> > > > get
> > > > > an update. Even in that case, forcefully merging a new feature,
> that
> > is
> > > > not
> > > > > a critical bug fix, at this point would be too risky.
> > > > >
> > > > > My preference would be to cut another release with OSGI, Cammel,
> and
> > > > > Node.JS early January (no point of doing it sooner due to
> holidays).
> > > > Would
> > > > > do you think?
> > > > >
> > > > >
> > > > > >
> > > > > > To the release manager: please take out the OSGi documentation
> from
> > > 1.5
> > > > > in
> > > > > > readme.io and put it in 1.6.
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > *Raúl Kripalani*
> > > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big
> > Data
> > > > and
> > > > > > Messaging Engineer
> > > > > > http://about.me/raulkripalani |
> > > > http://www.linkedin.com/in/raulkripalani
> > > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > > >
> > > > > > On Tue, Nov 24, 2015 at 8:11 PM, Raul Kripalani <
> raulk@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > > Hello all,
> > > > > > >
> > > > > > > The initial OSGi integration is ready for review in branch
> > > > ignite-1270.
> > > > > > > Features included:
> > > > > > >
> > > > > > > * OSGi manifest for most modules. I could OSGi-fy 22 modules.
> > Some
> > > > are
> > > > > > > left out due to complexity or not supporting OSGi: hadoop,
> mesos,
> > > > > cloud,
> > > > > > > gce, yarn, etc.
> > > > > > > * Karaf features repository with 1 feature per module + a
> global
> > > > > > > ignite-all feature. Each feature installs the required
> > dependencies
> > > > > into
> > > > > > > the container.
> > > > > > > * Ignite OSGi Bundle Activator which activates an Ignite OSGi
> > > > > > > configuration and injects the appropriate OSGi-friendly
> > > classloader.
> > > > > > > * Two classloading strategies for OSGi:
> > > > > > > * Bundle Delegating => attempts to find the class in the
> > bundle
> > > > > that
> > > > > > > loaded Ignite, falling back to ignite-core.
> > > > > > > * Container Sweep => same as above, but sweeps the entire
> > OSGi
> > > > > > > container for the first hit as the ultimate fallback (keeps a
> > > cache).
> > > > > > >
> > > > > > > (@Romain – the latter should work for you).
> > > > > > >
> > > > > > > Since generating the Karaf features repo (features.xml)
> requires
> > > > > > including
> > > > > > > version numbers of the 3rd party deps, I have promoted the
> > version
> > > > > > numbers
> > > > > > > I needed to parent/pom.xml as Maven properties. This is also a
> > > Maven
> > > > > best
> > > > > > > practice.
> > > > > > >
> > > > > > > In this branch, IGNITE-1810 is also included. I was able to
> test
> > it
> > > > > > > locally only, given that the CI test job is broken in TeamCity.
> > > > > > >
> > > > > > > Note: Spring configuration of Ignite is not supported due to
> > Spring
> > > > DM
> > > > > > > 1.2.1 not being compatible with Spring Framework 4.x anymore.
> > This
> > > is
> > > > > > being
> > > > > > > discussed at the SMX community [1]. For now, we only support
> > > > > programmatic
> > > > > > > configuration.
> > > > > > >
> > > > > > > As you know, I created a user guide section for OSGi in the 1.5
> > > docs
> > > > > [2].
> > > > > > >
> > > > > > > I'd like this feature to target 1.5. It does modify existing
> > Ignite
> > > > > > > codebase, so it should be pretty safe to release.
> > > > > > >
> > > > > > > [1]
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> http://servicemix.396122.n5.nabble.com/Spring-DM-for-Spring-4-in-SMX-Karaf-td5723130.html
> > > > > > > [2] https://dash.readme.io/project/apacheignite/v1.5
> > > > > > >
> > > > > > > *Raúl Kripalani*
> > > > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration,
> Big
> > > Data
> > > > > and
> > > > > > > Messaging Engineer
> > > > > > > http://about.me/raulkripalani |
> > > > > http://www.linkedin.com/in/raulkripalani
> > > > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: OSGi integration ready for review
Posted by Dmitriy Setrakyan <ds...@apache.org>.
Guys,
Should we try to review and merge the OSGI integration before the final
release? it does sound like it is additive and should not affect other
functionality.
My preference would be to get it in, so other OSGI-related integrations
(e.g. Camel) would not have to wait for 1.6.
Thoughts?
D.
On Mon, Nov 30, 2015 at 11:48 PM, Anton Vinogradov <avinogradov@gridgain.com
> wrote:
> Raul,
>
> I've added 1.6 space as a copy of 1.5.
> But I gain no results at OSGi search.
> Could you please specify what pages should be removed from 1.5 or revome
> them by yourself?
>
> On Mon, Nov 30, 2015 at 6:18 PM, Yakov Zhdanov <yz...@apache.org>
> wrote:
>
> > Raul, as far as commits - they are mostly fixes for functionality, but do
> > not add new features.
> >
> > Can someone create 1.6 space and move OSGi articles there? Perhaps, Anton
> > V. can do it?
> >
> > --Yakov
> >
> > 2015-11-30 16:42 GMT+03:00 Raul Kripalani <ra...@apache.org>:
> >
> > > Dmitriy,
> > >
> > > I'm not going to judge if the communication of release timelines is
> > > efficient. In fact, the release has still not been made and there's no
> > > traffic in the ML about what's going on. Commits are still being
> pushed,
> > no
> > > one knows anything. It seems communication is internal between
> > committers.
> > > But anyway, let's move ahead with OSGi.
> > >
> > > I have merged 1.5 into master, and master into ignite-1270. So it's now
> > > mergeable into 1.6
> > >
> > > Someone needs to remove OSGi from the readme.io and push it into 1.6
> > (not
> > > me, I'm not happy with all this).
> > >
> > > Regards,
> > >
> > > *Raúl Kripalani*
> > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data
> and
> > > Messaging Engineer
> > > http://about.me/raulkripalani |
> http://www.linkedin.com/in/raulkripalani
> > > http://blog.raulkr.net | twitter: @raulvk
> > >
> > > On Sat, Nov 28, 2015 at 5:13 AM, Dmitriy Setrakyan <
> > dsetrakyan@apache.org>
> > > wrote:
> > >
> > > > On Fri, Nov 27, 2015 at 5:48 PM, Raul Kripalani <ra...@apache.org>
> > > wrote:
> > > >
> > > > > Aside from Dmitriy's questions, was there any blocker for someone
> to
> > > > review
> > > > > the code? There has been no activity from committers.
> > > > >
> > > >
> > > > As I mentioned last week, we were planning to cut a release this
> > Friday,
> > > > but I don’t think it happened. I too would like to get an update.
> > Yakov,
> > > > can you send out the status on open issues?
> > > >
> > > >
> > > > > It was supposed to be merged for 1.5, and as far as I know, there
> was
> > > no
> > > > > official announcement in the dev@ list that the release was being
> > cut
> > > > > today. How is the dev team supposed to be synchronised around these
> > > > > milestones???
> > > > >
> > > >
> > > > Raul, I am hoping the release will happen over the weekend, assuming
> we
> > > get
> > > > an update. Even in that case, forcefully merging a new feature, that
> is
> > > not
> > > > a critical bug fix, at this point would be too risky.
> > > >
> > > > My preference would be to cut another release with OSGI, Cammel, and
> > > > Node.JS early January (no point of doing it sooner due to holidays).
> > > Would
> > > > do you think?
> > > >
> > > >
> > > > >
> > > > > To the release manager: please take out the OSGi documentation from
> > 1.5
> > > > in
> > > > > readme.io and put it in 1.6.
> > > > >
> > > > > Regards,
> > > > >
> > > > > *Raúl Kripalani*
> > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big
> Data
> > > and
> > > > > Messaging Engineer
> > > > > http://about.me/raulkripalani |
> > > http://www.linkedin.com/in/raulkripalani
> > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > >
> > > > > On Tue, Nov 24, 2015 at 8:11 PM, Raul Kripalani <ra...@apache.org>
> > > > wrote:
> > > > >
> > > > > > Hello all,
> > > > > >
> > > > > > The initial OSGi integration is ready for review in branch
> > > ignite-1270.
> > > > > > Features included:
> > > > > >
> > > > > > * OSGi manifest for most modules. I could OSGi-fy 22 modules.
> Some
> > > are
> > > > > > left out due to complexity or not supporting OSGi: hadoop, mesos,
> > > > cloud,
> > > > > > gce, yarn, etc.
> > > > > > * Karaf features repository with 1 feature per module + a global
> > > > > > ignite-all feature. Each feature installs the required
> dependencies
> > > > into
> > > > > > the container.
> > > > > > * Ignite OSGi Bundle Activator which activates an Ignite OSGi
> > > > > > configuration and injects the appropriate OSGi-friendly
> > classloader.
> > > > > > * Two classloading strategies for OSGi:
> > > > > > * Bundle Delegating => attempts to find the class in the
> bundle
> > > > that
> > > > > > loaded Ignite, falling back to ignite-core.
> > > > > > * Container Sweep => same as above, but sweeps the entire
> OSGi
> > > > > > container for the first hit as the ultimate fallback (keeps a
> > cache).
> > > > > >
> > > > > > (@Romain – the latter should work for you).
> > > > > >
> > > > > > Since generating the Karaf features repo (features.xml) requires
> > > > > including
> > > > > > version numbers of the 3rd party deps, I have promoted the
> version
> > > > > numbers
> > > > > > I needed to parent/pom.xml as Maven properties. This is also a
> > Maven
> > > > best
> > > > > > practice.
> > > > > >
> > > > > > In this branch, IGNITE-1810 is also included. I was able to test
> it
> > > > > > locally only, given that the CI test job is broken in TeamCity.
> > > > > >
> > > > > > Note: Spring configuration of Ignite is not supported due to
> Spring
> > > DM
> > > > > > 1.2.1 not being compatible with Spring Framework 4.x anymore.
> This
> > is
> > > > > being
> > > > > > discussed at the SMX community [1]. For now, we only support
> > > > programmatic
> > > > > > configuration.
> > > > > >
> > > > > > As you know, I created a user guide section for OSGi in the 1.5
> > docs
> > > > [2].
> > > > > >
> > > > > > I'd like this feature to target 1.5. It does modify existing
> Ignite
> > > > > > codebase, so it should be pretty safe to release.
> > > > > >
> > > > > > [1]
> > > > > >
> > > > >
> > > >
> > >
> >
> http://servicemix.396122.n5.nabble.com/Spring-DM-for-Spring-4-in-SMX-Karaf-td5723130.html
> > > > > > [2] https://dash.readme.io/project/apacheignite/v1.5
> > > > > >
> > > > > > *Raúl Kripalani*
> > > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big
> > Data
> > > > and
> > > > > > Messaging Engineer
> > > > > > http://about.me/raulkripalani |
> > > > http://www.linkedin.com/in/raulkripalani
> > > > > > http://blog.raulkr.net | twitter: @raulvk
> > > > > >
> > > > >
> > > >
> > >
> >
>