You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/06/19 23:11:00 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #522: PHOENIX-5359: Remove (Global-Indexing)new coprocessors in CQSI#addCop…

swaroopak commented on a change in pull request #522: PHOENIX-5359: Remove (Global-Indexing)new coprocessors in CQSI#addCop…
URL: https://github.com/apache/phoenix/pull/522#discussion_r295559601
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ##########
 @@ -911,7 +911,9 @@ private void addCoprocessors(byte[] tableName, TableDescriptorBuilder builder, P
                     QueryServicesOptions.DEFAULT_INDEX_REGION_OBSERVER_ENABLED);
 
             if (tableType == PTableType.INDEX && !isTransactional) {
-                if (globalIndexerEnabled && !newDesc.hasCoprocessor(GlobalIndexChecker.class.getName())) {
+                if (!globalIndexerEnabled && newDesc.hasCoprocessor(GlobalIndexChecker.class.getName())) {
 
 Review comment:
   I think it should be more generic to reflect newer design parameter.  What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services