You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by tu...@apache.org on 2023/05/11 17:04:02 UTC

[arrow-rs] branch master updated: Skip test_list_root on OS X (#3772) (#4198)

This is an automated email from the ASF dual-hosted git repository.

tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/master by this push:
     new d6c3c01aa Skip test_list_root on OS X (#3772) (#4198)
d6c3c01aa is described below

commit d6c3c01aafdaea2b2b1051d76c4e604ffffd72b0
Author: Raphael Taylor-Davies <17...@users.noreply.github.com>
AuthorDate: Thu May 11 18:03:56 2023 +0100

    Skip test_list_root on OS X (#3772) (#4198)
    
    * Skip test_list_root if cannot list root filesystem (#3772)
    
    * do not run on max
    
    * Remove list check
    
    ---------
    
    Co-authored-by: Andrew Lamb <an...@nerdnetworks.org>
---
 object_store/src/local.rs | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/object_store/src/local.rs b/object_store/src/local.rs
index 286853da2..b40f5a777 100644
--- a/object_store/src/local.rs
+++ b/object_store/src/local.rs
@@ -1117,19 +1117,23 @@ mod tests {
     }
 
     #[tokio::test]
+    #[cfg(target_family = "windows")]
     async fn test_list_root() {
-        let integration = LocalFileSystem::new();
-        let result = integration.list_with_delimiter(None).await;
-        if cfg!(target_family = "windows") {
-            let r = result.unwrap_err().to_string();
-            assert!(
-                r.contains("Unable to convert URL \"file:///\" to filesystem path"),
-                "{}",
-                r
-            );
-        } else {
-            result.unwrap();
-        }
+        let fs = LocalFileSystem::new();
+        let r = fs.list_with_delimiter(None).await.unwrap_err().to_string();
+
+        assert!(
+            r.contains("Unable to convert URL \"file:///\" to filesystem path"),
+            "{}",
+            r
+        );
+    }
+
+    #[tokio::test]
+    #[cfg(target_os = "linux")]
+    async fn test_list_root() {
+        let fs = LocalFileSystem::new();
+        fs.list_with_delimiter(None).await.unwrap();
     }
 
     async fn check_list(