You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/17 18:54:20 UTC
[GitHub] [beam] lostluck opened a new pull request #13366: [BEAM-9615] Switch options for logical types.
lostluck opened a new pull request #13366:
URL: https://github.com/apache/beam/pull/13366
Turns out Logical Types were the correct way to solve the int problem. Who knew?
This only tests the "to and from schema" type specifications half, and not the encoding decoding half of logical types, so those conversions are subject to change. However, I wanted to get this part in because I'm working on not needing to write similar structures for encoders, decoders, toSchemas, and FromSchemas for all the provisioning as well.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #13366:
URL: https://github.com/apache/beam/pull/13366#issuecomment-729131830
Run Go PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #13366:
URL: https://github.com/apache/beam/pull/13366#discussion_r526267284
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/logicaltypes.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package schema
+
+import (
+ "fmt"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+var (
+ // Maps logical type identifiers to their reflect.Type and the schema representation.
+ // the type identifier is the reflect.Type name, and included in the proto as well.
+ // We don't treat all types as "logical" types.
+ // ... why don't we treat all types as Logical types?
+ logicalTypes = map[string]LogicalType{}
+ logicalIdentifiers = map[reflect.Type]string{}
Review comment:
Good question: the string lookup is because that's all we have from the Schema proto direction. We need a mapping to the Logical part regardless, and then we need a mapping from the reflect.Type to that identifier. There's no guarantee or reason that a logical type's identifier will actually be related to the reflect.Type information unfortunately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #13366:
URL: https://github.com/apache/beam/pull/13366#discussion_r526284530
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go
##########
@@ -412,12 +382,18 @@ func fieldTypeToReflectType(sft *pipepb.FieldType, opts []*pipepb.Option) (refle
// case *pipepb.FieldType_IterableType:
// TODO(BEAM-9615): handle IterableTypes.
- //case *pipepb.FieldType_LogicalType:
- // TODO(BEAM-9615): handle LogicalTypes types.
- //sft.GetLogicalType().
+ case *pipepb.FieldType_LogicalType:
+ lst := sft.GetLogicalType()
+ identifier := lst.GetUrn()
+ lt, ok := logicalTypes[identifier]
+ if !ok {
+ return nil, errors.Errorf("unknown logical type: %v", identifier)
+ }
+ t = lt.GoType()
// Logical Types are for things that have more specialized user representation already, or
- // things like Time or protocol buffers.
+ // things like Time or protocol buffers, or int.
+ // Or specifically formatted integers.
Review comment:
The whole block is not necessary now that there's an entire file for the types. removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #13366:
URL: https://github.com/apache/beam/pull/13366#issuecomment-729131930
R: @youngoli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on a change in pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
youngoli commented on a change in pull request #13366:
URL: https://github.com/apache/beam/pull/13366#discussion_r525738322
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/logicaltypes.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package schema
+
+import (
+ "fmt"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+var (
+ // Maps logical type identifiers to their reflect.Type and the schema representation.
+ // the type identifier is the reflect.Type name, and included in the proto as well.
+ // We don't treat all types as "logical" types.
+ // ... why don't we treat all types as Logical types?
+ logicalTypes = map[string]LogicalType{}
+ logicalIdentifiers = map[reflect.Type]string{}
+)
+
+// LogicalType is an interface between custom Go types, and schema storage types.
+//
+// A LogicalType is a way to define a new type that can be stored in a schema field
+// using a known underlying type for storage. The storage type must be comprised of
+// known schema field types, or pre-registered LogicalTypes. LogicalTypes may not be
+// mutually recursive at any level of indirection.
+//End
Review comment:
Is this godoc-related or just something accidentally left in?
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/logicaltypes.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package schema
+
+import (
+ "fmt"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+var (
+ // Maps logical type identifiers to their reflect.Type and the schema representation.
+ // the type identifier is the reflect.Type name, and included in the proto as well.
+ // We don't treat all types as "logical" types.
+ // ... why don't we treat all types as Logical types?
+ logicalTypes = map[string]LogicalType{}
+ logicalIdentifiers = map[reflect.Type]string{}
Review comment:
I don't understand the reason to have the ID layer between logicalIdentifiers and logicalTypes. Is there a reason not to just have this?:
```suggestion
logicalTypes = map[reflect.Type]LogicalType{}
```
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go
##########
@@ -412,12 +382,18 @@ func fieldTypeToReflectType(sft *pipepb.FieldType, opts []*pipepb.Option) (refle
// case *pipepb.FieldType_IterableType:
// TODO(BEAM-9615): handle IterableTypes.
- //case *pipepb.FieldType_LogicalType:
- // TODO(BEAM-9615): handle LogicalTypes types.
- //sft.GetLogicalType().
+ case *pipepb.FieldType_LogicalType:
+ lst := sft.GetLogicalType()
+ identifier := lst.GetUrn()
+ lt, ok := logicalTypes[identifier]
+ if !ok {
+ return nil, errors.Errorf("unknown logical type: %v", identifier)
+ }
+ t = lt.GoType()
// Logical Types are for things that have more specialized user representation already, or
- // things like Time or protocol buffers.
+ // things like Time or protocol buffers, or int.
+ // Or specifically formatted integers.
Review comment:
Nit: This line can just be part of the previous line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #13366:
URL: https://github.com/apache/beam/pull/13366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on a change in pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
youngoli commented on a change in pull request #13366:
URL: https://github.com/apache/beam/pull/13366#discussion_r526448886
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/logicaltypes.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package schema
+
+import (
+ "fmt"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+var (
+ // Maps logical type identifiers to their reflect.Type and the schema representation.
+ // the type identifier is the reflect.Type name, and included in the proto as well.
+ // We don't treat all types as "logical" types.
+ // ... why don't we treat all types as Logical types?
+ logicalTypes = map[string]LogicalType{}
+ logicalIdentifiers = map[reflect.Type]string{}
Review comment:
Ack, that makes sense. I hadn't considered what to do when coming from the proto direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #13366: [BEAM-9615] Switch options for logical types.
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #13366:
URL: https://github.com/apache/beam/pull/13366#issuecomment-729836760
Run Go PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org