[GitHub] [trafficserver] rob05c commented on a change in pull request #7276: Remove the last remnants of the enable_url_expandomatic

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #7276:
URL: https://github.com/apache/trafficserver/pull/7276#discussion_r512290716



##########
File path: proxy/http/HttpTransact.cc
##########
@@ -1856,12 +1852,9 @@ HttpTransact::ReDNSRoundRobin(State *s)
 void
 HttpTransact::OSDNSLookup(State *s)
 {
-  static const int max_dns_lookups = 3;
-
   ink_assert(s->dns_info.looking_up == ORIGIN_SERVER);
 
-  TxnDebug("http_trans", "[HttpTransact::OSDNSLookup] This was attempt %d", s->dns_info.attempts);

Review comment:
       I'm not clear on the `DNS_ATTEMPTS_EXHAUSTED` and `max_dns_lookups` removal below. 
   Do these changes make it impossible for `OSDNSLookup` to ever be called more than once in a Transaction?
   
   If not, is this debug message useful to people?
   If so, I see asserts below, how do we now make sure we don't somehow have a loop?
   Also, with the removal of the "expanded name" stuff, why would `OSDNSLookup` ever need to be called more than once for the same transaction?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org