You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 03:55:47 UTC

[GitHub] [spark] srowen commented on a change in pull request #35505: [SPARK-38197][CORE] Improve error message of BlockManager.fetchRemoteManagedBuffer

srowen commented on a change in pull request #35505:
URL: https://github.com/apache/spark/pull/35505#discussion_r808654713



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -1143,7 +1143,8 @@ private[spark] class BlockManager(
         val buf = blockTransferService.fetchBlockSync(loc.host, loc.port, loc.executorId,
           blockId.toString, tempFileManager)
         if (blockSize > 0 && buf.size() == 0) {
-          throw new IllegalStateException("Empty buffer received for non empty block")
+          throw new IllegalStateException(s"Empty buffer received for non empty block " +

Review comment:
       Small nits: no need for interpolation on first half of string; "fetch" -> "fetching"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org