You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/05/16 21:23:20 UTC

[1/2] commons-release-plugin git commit: Fix file handle leak.

Repository: commons-release-plugin
Updated Branches:
  refs/heads/master 46ed2ce15 -> 7a3be9d5e


Fix file handle leak.

Project: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/commit/b7b204cc
Tree: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/tree/b7b204cc
Diff: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/diff/b7b204cc

Branch: refs/heads/master
Commit: b7b204cc21639062135fd14417d8eda567b70d89
Parents: ceecf0e
Author: Gary Gregory <ga...@gmail.com>
Authored: Wed May 16 15:22:45 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Wed May 16 15:22:45 2018 -0600

----------------------------------------------------------------------
 .../release/plugin/mojos/CommonsDistributionDetachmentMojo.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-release-plugin/blob/b7b204cc/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
index e67bbe5..6892386 100644
--- a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
+++ b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
@@ -176,9 +176,8 @@ public class CommonsDistributionDetachmentMojo extends AbstractMojo {
      * @throws MojoExecutionException if we cant write the file due to an {@link IOException}.
      */
     private void logAllArtifactsInPropertiesFile() throws MojoExecutionException {
-        try {
-            File sha1PropertiesFile = new File(workingDirectory, "sha1.properties");
-            FileOutputStream fileWriter = new FileOutputStream(sha1PropertiesFile);
+        File sha1PropertiesFile = new File(workingDirectory, "sha1.properties");
+        try (FileOutputStream fileWriter = new FileOutputStream(sha1PropertiesFile)) {
             artifactSha1s.store(fileWriter, "release sha1s");
         } catch (IOException e) {
             throw new MojoExecutionException("Failure to write sha1's", e);


[2/2] commons-release-plugin git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-release-plugin.git

Posted by gg...@apache.org.
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-release-plugin.git

Project: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/commit/7a3be9d5
Tree: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/tree/7a3be9d5
Diff: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/diff/7a3be9d5

Branch: refs/heads/master
Commit: 7a3be9d5eafae96d20508766716f3984e1a99f6f
Parents: b7b204c 46ed2ce
Author: Gary Gregory <ga...@gmail.com>
Authored: Wed May 16 15:23:00 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Wed May 16 15:23:00 2018 -0600

----------------------------------------------------------------------
 .../release/plugin/mojos/CommonsDistributionStagingMojo.java       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------