You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2014/03/03 12:24:22 UTC
[jira] [Commented] (QPID-5577) [Java Broker] Exchange, Queue and
Binding implementations should implement ConfiguredObject
[ https://issues.apache.org/jira/browse/QPID-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917963#comment-13917963 ]
Robbie Gemmell commented on QPID-5577:
--------------------------------------
https://svn.apache.org/r1572343
===============================
>From AbstractQueue:
- Priorities is overridden in the place it needs to be, but the others appear to be unused, and potential duplicates of other values.
{noformat}
+ @Override
+ public boolean isQueueFlowStopped()
+ {
+ return false;
+ }
+
+ @Override
+ public int getPriorities()
+ {
+ return 0;
+ }
+
+ @Override
+ public long getBytesIn()
+ {
+ return 0;
+ }
+
+ @Override
+ public long getBytesOut()
+ {
+ return 0;
+ }
+
+ @Override
+ public long getMessagesIn()
+ {
+ return 0;
+ }
+
+ @Override
+ public long getMessagesOut()
+ {
+ return 0;
+ }
{noformat}
>From QueueConsumerImpl:
- Currently unused, but StackOverflowException in waiting:
{noformat}
+ @Override
+ public boolean isNoLocal()
+ {
+ return isNoLocal();
+ }
+
{noformat}
Some test bits:
- Hmm?
{noformat}
@@ -60,6 +60,10 @@ public class StandardQueueTest extends AbstractQueueTestBase<StandardQueueEntry,
assertTrue("Exception was not about missing vhost",
e.getMessage().contains("Host"));
}
+ catch(NullPointerException e)
+ {
+
+ }
}
{noformat}
- Unclear this is needed?
{noformat}
@@ -53,6 +53,8 @@ public class AddressBasedDestinationTest extends QpidBrokerTestCase
@Override
public void setUp() throws Exception
{
+ setVirtualHostConfigurationProperty("virtualhosts.virtualhost.test.queues.maximumDeliveryCount",
+ "0");
{noformat}
> [Java Broker] Exchange, Queue and Binding implementations should implement ConfiguredObject
> -------------------------------------------------------------------------------------------
>
> Key: QPID-5577
> URL: https://issues.apache.org/jira/browse/QPID-5577
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Robbie Gemmell
> Fix For: 0.27
>
>
> Currently we wrap the implementation objects with Adapters to provide configured objects for management. Instead the implementations should provide the configured object interface, and the adapters be removed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org