[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6440: Add authentication for write endpoints of Controller resources

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #6440:
URL: https://github.com/apache/incubator-pinot/pull/6440#issuecomment-765860188


   > > So, we are still making the assumption that the client credentials are sent via http headers. I suppose that is OK, but maybe we should also add an interface that passes the client's identity (as received via https auth) to the auth interface we have? We do have https now.
   > 
   > You mean mTLS identity? Authentication should be decoupled from protocol. Fair point to not assume http headers assumption.
   
   Agreed about separating authentication and protocol, but you cannot do much authentication sending cleartext stuff back and forth. Anyone can impersonate easily. Even with https, if we have header based auth, it is easy to just insert some header and do what one wants to do. 
   
   In these cases, it translates to very weak (if any) authentication.
   
   We used this as a first round in trusted environments. With cloud based deployments in place, I am not sure if this holds true all the time


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org