You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/15 21:35:53 UTC

[GitHub] [pinot] richardstartin commented on a change in pull request #7769: Check interrupt flag in acquire

richardstartin commented on a change in pull request #7769:
URL: https://github.com/apache/pinot/pull/7769#discussion_r749698961



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/AcquireReleaseColumnsSegmentOperator.java
##########
@@ -64,6 +65,10 @@ protected IntermediateResultsBlock getNextBlock() {
    * Acquires the indexSegment using the provided fetchContext
    */
   public void acquire() {
+    // do not acquire if interrupted (similar to the check inside the nextBlock())
+    if (Thread.currentThread().isInterrupted()) {

Review comment:
       Clearing the interrupted status requires `Thread.interrupted()` instead. See [javadoc](https://docs.oracle.com/javase/7/docs/api/java/lang/Thread.html#interrupted())




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org