You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/19 22:35:19 UTC
[GitHub] [tvm] guberti opened a new pull request, #11067: [microTVM] Bump versions in reference vm
guberti opened a new pull request, #11067:
URL: https://github.com/apache/tvm/pull/11067
Previously, the Spresense SDK and `arduino-cli` had major bugs that required really nasty fixes in `base_box_provision.sh` (see https://github.com/sonydevworld/spresense/issues/200 and https://github.com/arduino/arduino-cli/pull/1312, respectively).
Both of these have been fixed in the latest versions, though. This PR updates the `arduino-cli` version to `0.21.1`, and sets the Spresense version to a generic latest version (as we do this for all the other board URLs). These allow us to remove the ugly hacks from `base_box_provision.sh`.
Note that this PR requires merging #11043.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] guberti commented on a diff in pull request #11067: [microTVM] Bump versions in reference vm
Posted by GitBox <gi...@apache.org>.
guberti commented on code in PR #11067:
URL: https://github.com/apache/tvm/pull/11067#discussion_r856601970
##########
apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh:
##########
@@ -47,9 +47,8 @@ sudo usermod -a -G dialout $USER
# 3rd party board URLs
ADAFRUIT_BOARDS_URL="https://adafruit.github.io/arduino-board-index/package_adafruit_index.json"
ESP32_BOARDS_URL="https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json"
-SPARKFUN_BOARDS_URL="https://raw.githubusercontent.com/sparkfun/Arduino_Boards/master/IDE_Board_Manager/package_sparkfun_index.json"
SEEED_BOARDS_URL="https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json"
-SPRESENSE_BOARDS_URL="https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/v2.2.1/package_spresense_index.json"
+SPRESENSE_BOARDS_URL="https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/generic/package_spresense_index.json"
Review Comment:
Good point. I originally made this change to keep everything consistent, but I've now updated it so that all the board library versions are fixed (as is the case for Zephyr).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] guberti commented on pull request #11067: [microTVM] Bump versions in reference vm
Posted by GitBox <gi...@apache.org>.
guberti commented on PR #11067:
URL: https://github.com/apache/tvm/pull/11067#issuecomment-1106049039
I've verified the Arduino integration tests pass with these version bumps. Once #11095 merges, we are free to merge this. @mehrdadh would you mind reviewing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #11067: [microTVM] Bump versions in reference vm
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #11067:
URL: https://github.com/apache/tvm/pull/11067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] guberti commented on pull request #11067: [microTVM] Bump versions in reference vm
Posted by GitBox <gi...@apache.org>.
guberti commented on PR #11067:
URL: https://github.com/apache/tvm/pull/11067#issuecomment-1106938350
> Glad to see CI is working again. @guberti Thanks for working on this. Looks good overall, just added a suggestion and some clarification question.
Made a change to lock versions for all the libraries. Thanks for taking a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] guberti commented on a diff in pull request #11067: [microTVM] Bump versions in reference vm
Posted by GitBox <gi...@apache.org>.
guberti commented on code in PR #11067:
URL: https://github.com/apache/tvm/pull/11067#discussion_r856601359
##########
docker/install/ubuntu_install_arduino.sh:
##########
@@ -23,7 +23,7 @@ set -o pipefail
export DEBIAN_FRONTEND=noninteractive
apt-get install -y ca-certificates
-ARDUINO_CLI_VERSION="0.18.3"
+ARDUINO_CLI_VERSION="0.21.1"
Review Comment:
We decided last summer that the scripts should be separate, as they aren't that similar. I'd be open to revisiting that topic, but it's OOS for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11067: [microTVM] Bump versions in reference vm
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11067:
URL: https://github.com/apache/tvm/pull/11067#discussion_r856411646
##########
docker/install/ubuntu_install_arduino.sh:
##########
@@ -23,7 +23,7 @@ set -o pipefail
export DEBIAN_FRONTEND=noninteractive
apt-get install -y ca-certificates
-ARDUINO_CLI_VERSION="0.18.3"
+ARDUINO_CLI_VERSION="0.21.1"
Review Comment:
can you consolidate arduino CLI installation into one script and reuse for both docker and RVM?
##########
apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh:
##########
@@ -47,9 +47,8 @@ sudo usermod -a -G dialout $USER
# 3rd party board URLs
ADAFRUIT_BOARDS_URL="https://adafruit.github.io/arduino-board-index/package_adafruit_index.json"
ESP32_BOARDS_URL="https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json"
-SPARKFUN_BOARDS_URL="https://raw.githubusercontent.com/sparkfun/Arduino_Boards/master/IDE_Board_Manager/package_sparkfun_index.json"
SEEED_BOARDS_URL="https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json"
-SPRESENSE_BOARDS_URL="https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/v2.2.1/package_spresense_index.json"
+SPRESENSE_BOARDS_URL="https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/generic/package_spresense_index.json"
Review Comment:
can you explain what is generic here?
I think the idea of RVM is to use fixed versions so we can reproduce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org