You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/11/02 02:55:46 UTC
[PR] [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes [hudi]
boneanxs opened a new pull request, #9972:
URL: https://github.com/apache/hudi/pull/9972
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
1. Change `TestWaitBasedTimeGenerator` to a unique path since if other tests(like `TestHoodieActiveTimeline`) initialize `TimeGenerator` firstly, then `MockInProcessLockProvider` cannot be used.
2. Name change `locked` -> `skipLocking` to follow HUDI existing naming style.
3. Fix usage of `DEFAULT_LOCK_ACQUIRE_WAIT_TIMEOUT_MS`
### Impact
_Describe any public API or user-facing feature change or any performance impact._
None
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes [hudi]
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs closed pull request #9972: [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes
URL: https://github.com/apache/hudi/pull/9972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9972:
URL: https://github.com/apache/hudi/pull/9972#issuecomment-1790006848
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b66c87be553dd7f7a5b362b3d808eb66f9c29d40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b66c87be553dd7f7a5b362b3d808eb66f9c29d40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b66c87be553dd7f7a5b362b3d808eb66f9c29d40 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9972:
URL: https://github.com/apache/hudi/pull/9972#issuecomment-1790649859
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b66c87be553dd7f7a5b362b3d808eb66f9c29d40",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20632",
"triggerID" : "b66c87be553dd7f7a5b362b3d808eb66f9c29d40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b66c87be553dd7f7a5b362b3d808eb66f9c29d40 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20632)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9972:
URL: https://github.com/apache/hudi/pull/9972#issuecomment-1790012121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b66c87be553dd7f7a5b362b3d808eb66f9c29d40",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20632",
"triggerID" : "b66c87be553dd7f7a5b362b3d808eb66f9c29d40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b66c87be553dd7f7a5b362b3d808eb66f9c29d40 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20632)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-1623][FOLLOW_UP] Fix test TestWaitBasedTimeGenerator & refine codes [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9972:
URL: https://github.com/apache/hudi/pull/9972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org