You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "aljazerzen (via GitHub)" <gi...@apache.org> on 2023/04/13 16:24:09 UTC

[GitHub] [arrow] aljazerzen commented on pull request #35067: GH-35067: [JavaScript] toString for signed `BigNum`s

aljazerzen commented on PR #35067:
URL: https://github.com/apache/arrow/pull/35067#issuecomment-1507250762

   I've spent a little time trying to get tests to pass, but something strange is happening:
   
   the `bn-tests.ts` are failing only on `-t es5 -m umd`. I've debugged it to the finding that in [this line](https://github.com/apache/arrow/pull/35067/files#diff-f0dbeeadc965880cf706bd8b8776f24dacf74f260b1faa5c60e4d62dbb76ecd7R101), `a.signed` is false, even though I've constructed a signed number or a decimal (which is signed).
   
   It may be a problem with how these prototypes are assigning to each other, but that is beyond me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org