You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/01 09:10:24 UTC

[GitHub] [iotdb] jt2594838 commented on a change in pull request #2958: [IOTDB-1266]SHOW TIMESERIES will only display 2000 timeseries

jt2594838 commented on a change in pull request #2958:
URL: https://github.com/apache/iotdb/pull/2958#discussion_r605496583



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -1519,7 +1519,6 @@ public MNode getMNode(MNode deviceMNode, String measurementName) {
     // do not use limit and offset in sub-queries unless offset is 0, otherwise the results are
     // not combinable
     if (offset != 0) {
-      plan.setLimit(0);

Review comment:
       This should not be removed. Consider this case: 
   The offset is 10000, the limit is 10, and the results are distributed on 3 nodes. If you keep the limit, each of the 3 nodes will only return 10 results, 30 results in total, which will all be filtered when the offset is applied.
   You may set the limit to `limit + offset` so the unnecessary fetch can be reduced.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org