You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Rodolfo Hansen (JIRA)" <ji...@apache.org> on 2010/11/08 07:28:14 UTC
[jira] Created: (WICKET-3151) ModalWindow support for nested iframe
windows
ModalWindow support for nested iframe windows
---------------------------------------------
Key: WICKET-3151
URL: https://issues.apache.org/jira/browse/WICKET-3151
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.4.13
Reporter: Rodolfo Hansen
Priority: Minor
I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: modal.patch
Patch that excludes white space fixes.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modal.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966919#action_12966919 ]
Martin Grigorov commented on WICKET-3151:
-----------------------------------------
I'll need more information here before applying the patch.
The attached quickstart works perfectly with current 1.4-SNAPSHOT. It doesn't use iframes at all and it doesn't change the request target.
Can you please update the ticket description as well ? Now to understand the ticket one has to read the patch and there is a possibility for confusions.
Thanks!
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Stefan Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279612#comment-13279612 ]
Stefan Lindner commented on WICKET-3151:
----------------------------------------
Will this be fixed in Wicket 6 wit jQuery? It would be a pleasure if we can mix page und panel modal windows.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930300#action_12930300 ]
Rodolfo Hansen commented on WICKET-3151:
----------------------------------------
Here is the cleaned up patch.
I will submit a patch that homogenises the undefined tests as another bug.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modal.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Assigned] (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3151:
---------------------------------------
Assignee: (was: Martin Grigorov)
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930541#action_12930541 ]
Rodolfo Hansen commented on WICKET-3151:
----------------------------------------
there is an issue with the patch.
Am testing further changes..
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modal.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Edwin Ariel Ferreira Betances (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edwin Ariel Ferreira Betances updated WICKET-3151:
--------------------------------------------------
Attachment: modalFormClose.zip
Example of errors fixed by patch
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Description:
I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
was:I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965007#action_12965007 ]
Rodolfo Hansen commented on WICKET-3151:
----------------------------------------
Another issue was discovered later on, and is included in this patch; I can attach a quickstart to show what the addressed issue is, and as proof it is fixed in the patch.
Should I attach it to this bug, or another?
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Edwin Ariel Ferreira Betances (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004229#comment-13004229 ]
Edwin Ariel Ferreira Betances commented on WICKET-3151:
-------------------------------------------------------
I have added a quickstart which demonstrates the problems addressed by this patch
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: modalFormClose.zip
Quickstart to test whether a form included as an iframe will load correctly.
Also shows it closes even if the RequestTarget has been subsequently replaced.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: (was: modal.patch)
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: (was: modalFormClose.zip)
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: modalWindow.patch
The modalWindow patch no longer attempts to modify the request target for iframe modals that are working with a lost ajaxRequestTarget
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: modal.patch
Patch to better implement the nesting of modal windows.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modal.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: modalWindow.patch
Here is the updated patch
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: (was: modalWindow.patch)
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types.
> The current implementation is unable to correctly track and close modal windows when any of the modal windows is inside an iframe
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964528#action_12964528 ]
Martin Grigorov commented on WICKET-3151:
-----------------------------------------
What's the state of the patch ? Last comment says "it is not ready to use yet".
Can you provide quickstart app that uses the new functionality ? Or just update the example at wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/modal
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modal.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3151) ModalWindow support for nested iframe
windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3151:
-----------------------------------
Attachment: (was: modal.patch)
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967031#action_12967031 ]
Rodolfo Hansen commented on WICKET-3151:
----------------------------------------
You will notice the modal window is not hidden once the button is clicked unless the patch is included.
Also, the modal page IS presented in an iframe, use firebug *after* it has being shown.
You are right regarding the quickstart not changing the request target, I will supply a new quickstart for that case.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3151:
---------------------------------------
Assignee: Martin Grigorov
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: modalFormClose.zip, modalWindow.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3151) ModalWindow support for nested
iframe windows
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930256#action_12930256 ]
Martin Grigorov commented on WICKET-3151:
-----------------------------------------
Rodolfo,
Thanks for the patch!
Can you re-attach a new one without the noise of changed whitespaces. There are many chunks in the patch which don't change anything.
> ModalWindow support for nested iframe windows
> ---------------------------------------------
>
> Key: WICKET-3151
> URL: https://issues.apache.org/jira/browse/WICKET-3151
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Minor
> Attachments: modal.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I think it would be better to better allow for modal window nested indistinguishable between iFrame and regular modal window types..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.