You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/21 06:52:57 UTC
[GitHub] [echarts] Ovilia opened a new pull request, #17944: fix(stack): revert pr #17809
Ovilia opened a new pull request, #17944:
URL: https://github.com/apache/echarts/pull/17944
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Revert pr #17809 because #17801 is not a bug but not used correctly.
v5.3.3 introduced a new option [stackStrategy](https://echarts.apache.org/zh/option.html#series-bar.stackStrategy), and if a series should always stack from 0 rather than other series, it should be set to `'negative'` or `'positive'`. If not set, the default value is `'samesign'` and the data should be stacked on other series no matter the other part of the series is positive or negative.
### Fixed issues
PR #17809 makes the test case `axis-filter-extent2.html` fail and was found before new version release.
## Details
### Before: What was the problem?
`axis-filter-extent2.html` fails.
### After: How does it behave after the fixing?
`axis-filter-extent2.html` doesn't fail and developers should set `stackStrategy: 'negative'` in cases like #17801 or #17942
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17944: fix(stack): revert pr #17809
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17944:
URL: https://github.com/apache/echarts/pull/17944#issuecomment-1321653919
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17944: fix(stack): revert pr #17809
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17944:
URL: https://github.com/apache/echarts/pull/17944#issuecomment-1321538738
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart merged pull request #17944: fix(stack): revert pr #17809
Posted by GitBox <gi...@apache.org>.
plainheart merged PR #17944:
URL: https://github.com/apache/echarts/pull/17944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org