[jira] [Assigned] (TS-1727) spdy plugin doesn't compile on Solaris 10

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom reassigned TS-1727:
---------------------------------

    Assignee: Igor Galić

Is this done ? If so, can we close this?
                
> spdy plugin doesn't compile on Solaris 10
> -----------------------------------------
>
>                 Key: TS-1727
>                 URL: https://issues.apache.org/jira/browse/TS-1727
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Plugins
>            Reporter: Igor Galić
>            Assignee: Igor Galić
>             Fix For: 3.3.2
>
>         Attachments: spdy-solaris.patch
>
>
> {noformat}
> bash-3.00$ gmake
>   CXX      protocol.lo
> protocol.cc: In function 'void spdy_send_syn_reply(spdy_io_stream*, const spdy::key_value_block&)':
> protocol.cc:71:91: error: 'MAX' was not declared in this scope
> protocol.cc:90:57: error: 'buffer' was not declared in this scope
> gmake: *** [protocol.lo] Error 1
> {noformat}
> This is caused by this code:
> {code}
>     uint8_t     buffer[
>         MAX((unsigned)spdy::message_header::size, (unsigned)spdy::syn_stream_message::size)];
>     size_t      nbytes = 0;
> {code}
> {{MAX}} comes from the same file:
> {code}
> #include <sys/param.h> // MAX
> {code}
> {noformat}
> -bash-3.00$ grep  MAX /usr/include/sys/param.h
> #ifndef MAX_INPUT
> #define MAX_INPUT       512     /* Maximum bytes stored in the input queue */
> #ifndef MAX_CANON
> #define MAX_CANON       256     /* Maximum bytes for canonical processing */
> #define MAX_TASKID      999999
> #define MAX_MAXPID      999999
> #define DEFAULT_MAXPID  999999
> #define DEFAULT_MAXPID  30000
> #define MAXUID          2147483647      /* max user id */
> #define MAXPROJID       MAXUID          /* max project id */
> #define MAXLINK         32767   /* max links */
>  * configurable parameter NGROUPS_MAX.
> #define NGROUPS_UMAX    32
>  * NGROUPS_MAX_DEFAULT: *MUST* match NGROUPS_MAX value in limits.h.
> #define NGROUPS_MAX_DEFAULT     16
>  * MAXPATHLEN defines the longest permissible path length,
>  * TYPICALMAXPATHLEN is used in a few places as an optimization
>  * MAXSYMLINKS defines the maximum number of symbolic links
>  * MAXNAMELEN is the length (including the terminating null) of
> #define MAXPATHLEN      1024
> #define TYPICALMAXPATHLEN       64
> #define MAXSYMLINKS     20
> #define MAXNAMELEN      256
> #ifndef PIPE_MAX        /* max # bytes written to a pipe in a write */
> #define PIPE_MAX        5120
> #endif  /* PIPE_MAX */
>  * The file system is made out of blocks of at most MAXBSIZE units,
>  * MAXBSIZE primarily determines the size of buffers in the buffer
> #define MAXBSIZE        8192
> #define MAXFRAG         8
> #define MAXOFF32_T      0x7fffffff
> #define MAXOFF_T        0x7fffffffffffffffl
> #define MAXOFFSET_T     0x7fffffffffffffffl
> #define MAXOFF_T        0x7fffffffl
> #define MAXOFFSET_T     0x7fffffffffffffffLL
> #define MAXOFFSET_T     0x7fffffff
> #define _AIO_LISTIO_MAX         (4096)
> #define _AIO_MAX                (-1)
> #define _MQ_OPEN_MAX            (-1)
> #define _MQ_PRIO_MAX            (32)
> #define _SEM_NSEMS_MAX          INT_MAX
> #define _SEM_VALUE_MAX          INT_MAX
> #define MAXPID          ((pid_t)_sysconf(_SC_MAXPID))
> {noformat}
> So… MAX WHAT?!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira