You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/06/04 14:46:07 UTC

[Bug 56588] New: ApplicationListener#pluggabilityBlocked field is always "false" in Tomcat 8

https://issues.apache.org/bugzilla/show_bug.cgi?id=56588

            Bug ID: 56588
           Summary: ApplicationListener#pluggabilityBlocked field is
                    always "false" in Tomcat 8
           Product: Tomcat 8
           Version: 8.0.8
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: knst.kolinko@gmail.com

(Noted when reviewing bug 55282 and its fix - r1597855 )

Apart from ~42 references in text code, the
o.a.t.util.descriptor.web.ApplicationListener constructor is called in only one
place and in that place [1] the pluggabilityBlocked argument is always "false".

[1] org.apache.catalina.startup.ContextConfig#configureContext(WebXml)


Originally this feature was added in r1492307 and this the second constructor
argument was named "fromTLD". The feature is that listeners added by TLD
scanning do not have access to all configuration APIs.

In Tomcat 8 Jasper now initializes itself via JasperInitializer.onStartup() and
adds TLD listeners via ServletContext.addListener(String) calls.

Thus:
1. I suspect that the feature implemented by r1492307 may be currently broken
which means that listeners defined in TLDs have access to full API.

2. ApplicationListener.pluggabilityBlocked field and a bunch of code can be
removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56588] ApplicationListener#pluggabilityBlocked field is always "false" in Tomcat 8

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56588

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
The feature isn't broken. The original fix included a test that still passes.
It works because all listeners added via ServletContext.addListener() are
blocked from using pluggability features.

I agree there is some unused code we can remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56588] ApplicationListener#pluggabilityBlocked field is always "false" in Tomcat 8

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56588

--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
Ack. I see.
In StandardContext.listenerStart() the listeners that have been already
configured before (via ServletContext API) are added to
'noPluggabilityListeners' set. That does the trick.

I updated deprecation markers on o.a.c.Context methods in Tomcat 7 in r1600638.
It will be in 7.0.55.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56588] ApplicationListener#pluggabilityBlocked field is always "false" in Tomcat 8

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56588

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Fixed in 8.0.x for 8.0.9 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org