You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/09/09 23:31:28 UTC

[jira] [Commented] (ZOOKEEPER-2031) Support tagging a QuorumServer

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127585#comment-14127585 ] 

Hadoop QA commented on ZOOKEEPER-2031:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12667482/ZOOKEEPER-2031.patch
  against trunk revision 1621313.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2319//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2319//console

This message is automatically generated.

> Support tagging a QuorumServer
> ------------------------------
>
>                 Key: ZOOKEEPER-2031
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2031
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: some one
>            Assignee: some one
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2031.patch, ZOOKEEPER-2031.patch
>
>
> Currently ZooKeeper only allows using the server id which is an integer for identifying servers. For my (unavoidable) use case, there may be concurrent dynamic removes and adds of servers which may eventually have id collisions. When this occurs, there is no good way to determine if the server (given an id collision) that we want to remove is the right server.
> To support my use case, I propose that we add a tag field to the server string.
> For my specific use case, this tag field will be used to store a uuid as a string.
> So for example:
> server.1=127.0.0.1:1234:1236:participant;0.0.0.0:1237;743b9d23-85cb-45b1-8949-930fdabb21f0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)