[GitHub] [ozone] adoroszlai commented on a diff in pull request #5267: HDDS-6618. [perf] Require successful basic checks for long-running tests

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #5267:
URL: https://github.com/apache/ozone/pull/5267#discussion_r1321252209


##########
.github/workflows/ci.yml:
##########
@@ -242,6 +273,7 @@ jobs:
     needs:
       - build-info
       - build
+      - basic-test

Review Comment:
   ```suggestion
         - basic
   ```



##########
.github/workflows/ci.yml:
##########
@@ -191,11 +193,7 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: 8
-      - name: Execute tests
-        run: hadoop-ozone/dev-support/checks/${{ matrix.check }}.sh
-      - name: Summary of failures
-        run: cat target/${{ matrix.check }}/summary.txt
-        if: ${{ !cancelled() }}

Review Comment:
   This part should not be removed, otherwise these basic checks become no-ops.



##########
.github/workflows/ci.yml:
##########
@@ -291,6 +323,7 @@ jobs:
     needs:
       - build-info
       - build
+      - basic-test

Review Comment:
   ```suggestion
         - basic
   ```



##########
.github/workflows/ci.yml:
##########
@@ -321,6 +354,8 @@ jobs:
   integration:
     needs:
       - build-info
+      - build
+      - basic-test

Review Comment:
   ```suggestion
         - basic
   ```



##########
.github/workflows/ci.yml:
##########
@@ -209,6 +207,39 @@ jobs:
           rm -rf ~/.m2/repository/org/apache/ozone/hdds*
           rm -rf ~/.m2/repository/org/apache/ozone/ozone*
         if: always()
+  basic-test:

Review Comment:
   ```suggestion
     unit:
   ```
   
   We also need to change `coverage` to depend on `unit` instead of `basic` (which no longer generates test coverage data).



##########
.github/workflows/ci.yml:
##########
@@ -209,6 +207,39 @@ jobs:
           rm -rf ~/.m2/repository/org/apache/ozone/hdds*
           rm -rf ~/.m2/repository/org/apache/ozone/ozone*
         if: always()
+  basic-test:
+    needs:
+      - build-info
+      - build

Review Comment:
   ```suggestion
         - basic
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org