You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Joerg Hoh (Jira)" <ji...@apache.org> on 2026/06/15 11:39:00 UTC

[jira] [Created] (OAK-12260) TokenLoginModule cannot handle many tokens in a performant way

Joerg Hoh created OAK-12260:
-------------------------------

             Summary: TokenLoginModule cannot handle many tokens in a performant way
                 Key: OAK-12260
                 URL: https://issues.apache.org/jira/browse/OAK-12260
             Project: Jackrabbit Oak
          Issue Type: Task
          Components: security
    Affects Versions: 1.80.0
            Reporter: Joerg Hoh



We had the situation in AEM, that requests, which are authenticating with a single use, where blocking like this:

{noformat}
       at java.util.concurrent.Semaphore.acquire(java.base@11.0.23/Semaphore.java:318)
        at org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.schedule(LockBasedScheduler.java:262)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore.merge(SegmentNodeStore.java:212)
        at org.apache.jackrabbit.oak.composite.CompositeNodeStore.merge(CompositeNodeStore.java:152)
        at org.apache.jackrabbit.oak.core.MutableRoot.commit(MutableRoot.java:261)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenProviderImpl.createToken(TokenProviderImpl.java:234)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenProviderImpl.createToken(TokenProviderImpl.java:187)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenLoginModule.commit(TokenLoginModule.java:173)
        at org.apache.felix.jaas.boot.ProxyLoginModule.commit(ProxyLoginModule.java:57)
        at javax.security.auth.login.LoginContext.invoke(java.base@11.0.23/LoginContext.java:750)
        at javax.security.auth.login.LoginContext$4.run(java.base@11.0.23/LoginContext.java:672)
        at javax.security.auth.login.LoginContext$4.run(java.base@11.0.23/LoginContext.java:670)
        at java.security.AccessController.doPrivileged(java.base@11.0.23/Native Method)
        at javax.security.auth.login.LoginContext.invokePriv(java.base@11.0.23/LoginContext.java:670)
        at javax.security.auth.login.LoginContext.login(java.base@11.0.23/LoginContext.java:582)
        at org.apache.jackrabbit.oak.core.ContentRepositoryImpl.login(ContentRepositoryImpl.java:170)
        at org.apache.jackrabbit.oak.jcr.repository.RepositoryImpl.login(RepositoryImpl.java:303)
{noformat}

while one of the requests looked like this:

{noformat}
t org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:650)
        at org.apache.jackrabbit.oak.composite.CompositeNodeState.compareAgainstBaseState(CompositeNodeState.java:163)
        at org.apache.jackrabbit.oak.spi.commit.EditorDiff.process(EditorDiff.java:51)
        at org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:54)
        at org.apache.jackrabbit.oak.spi.commit.CompositeHook.processCommit(CompositeHook.java:60)
        at org.apache.jackrabbit.oak.spi.commit.CompositeHook.processCommit(CompositeHook.java:60)
        at org.apache.jackrabbit.oak.composite.CommitHookEnhancer.processCommit(CommitHookEnhancer.java:55)
        at org.apache.jackrabbit.oak.segment.scheduler.Commit.apply(Commit.java:105)
        at org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.execute(LockBasedScheduler.java:299)
        at org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.schedule(LockBasedScheduler.java:270)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore.merge(SegmentNodeStore.java:212)
        at org.apache.jackrabbit.oak.composite.CompositeNodeStore.merge(CompositeNodeStore.java:152)
        at org.apache.jackrabbit.oak.core.MutableRoot.commit(MutableRoot.java:261)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenProviderImpl.cleanupExpired(TokenProviderImpl.java:485)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenProviderImpl.createToken(TokenProviderImpl.java:242)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenProviderImpl.createToken(TokenProviderImpl.java:187)
        at org.apache.jackrabbit.oak.security.authentication.token.TokenLoginModule.commit(TokenLoginModule.java:173)
[...]
{noformat}

In this particular case the created login-tokens were not re-used, but instead every request (from an automation) created a new login-token. Over time some 40k token nodes were accumulated, and it seems that as part of the login it is tried to cleanup.

While the re-use of an existing login-token should is advised, we cannot enforce it all ways. For that we need to improve this situation, so
# it's more obvious what's going on. For that I suggest that a warning should be logged as soon as more than 1k login-tokens were created. This is should be a noisy log entry, as the problem can be easy avoided by the user.
# We should see if it's possible to run this cleanup process in an async way.









--
This message was sent by Atlassian Jira
(v8.20.10#820010)