You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "asafm (via GitHub)" <gi...@apache.org> on 2023/04/03 09:31:27 UTC

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

asafm commented on code in PR #19832:
URL: https://github.com/apache/pulsar/pull/19832#discussion_r1155714389


##########
.github/ISSUE_TEMPLATE/pip.md:
##########
@@ -0,0 +1,151 @@
+---
+name: PIP
+about: Submit a Pulsar Improvement Proposal (PIP)
+title: 'PIP-XYZ: '
+labels: PIP
+---
+
+<!--
+RULES
+* Never place a link to an external site like Google Doc. The proposal should be in this issue entirely.
+* Use a spelling and grammar checker tools if available for you (there are plenty of free ones)
+
+PROPOSAL HEALTH CHECK
+I can read the design document and understand the problem statement and what you plan to change *without* resorting to a couple of hours of code reading just to start having a high level understanding of the change.
+-->
+
+# Background knowledge
+
+<!--
+Describes all the knowledge you need to know in order to understand all the other sections in this PIP
+
+* Give a high level explanation on all concepts you will be using throughout this document. For example, if you want to talk about Persistent Subscriptions, explain briefly (1 paragraph) what this is. If you're going to talk about Transaction Buffer, explain briefly what this is. 
+  If you're going to change something specific, then go into more detail about it and how it works. 
+* Provide links where possible if a person wants to dig deeper into the background information. 
+
+DON'T
+* Do not include links *instead* explanation. Do provide links for further explanation.
+
+EXAMPLES
+* See PIP-248, Background section to get an understanding on how you add the background knowledge needed.

Review Comment:
   Good suggestion. Added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org