You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "TylerBrinks (via GitHub)" <gi...@apache.org> on 2025/02/07 17:40:24 UTC

[PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

TylerBrinks opened a new pull request, #1715:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715

   Hi, I'm the maintainer of https://github.com/TylerBrinks/SqlParser-cs, a C# port of this library.  I'm finally getting around to submitting my first PR for this library based on an issue raised in the C# project.  
   
   This change updates the `Varbinary` type to take a `BinaryLength` similar to `Varchar` and `Nvarchar` where `IntegerLength` and `Max` is added to the enum.  This replaces the u64 parameter in order to allow both `varbinary(50)` and `varbinary(max)` syntas for MS Sql and Generic implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1715:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2656189253

   > @alamb Anything else I need to address? I'm learning the standard Rust way of doing things, hoping I got it right based on the PR checks in place.
   
   Nope -- sorry for the delay and thanks for the pink @TylerBrinks  -- I just lost track of this PR
   
   I gave it another look and it looks great to me ❤️ 
   
   🚀 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

Posted by "TylerBrinks (via GitHub)" <gi...@apache.org>.
TylerBrinks commented on PR #1715:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2655131625

   @alamb Anything else I need to address?  I'm learning the standard Rust way of doing things, hoping I got it right based on the PR checks in place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #1715:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1715:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2643662849

   > a C# port of this library.
   
   Very cool!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

Posted by "TylerBrinks (via GitHub)" <gi...@apache.org>.
TylerBrinks commented on PR #1715:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2649495366

   I think I got it right in the updated most recent push.  Awaiting approval if it passes the criteria.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org