You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/25 05:24:46 UTC
[PR] Code format for StandaloneContextManagerBuilderTest [shardingsphere]
terrymanu opened a new pull request, #38917:
URL: https://github.com/apache/shardingsphere/pull/38917
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Code format for StandaloneContextManagerBuilderTest [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38917:
URL: https://github.com/apache/shardingsphere/pull/38917#issuecomment-4796182908
### Summary
**Review Result: Mergeable**
Reason: The latest PR head changes only one private helper in `StandaloneContextManagerBuilderTest`, from `private static` to `private`, with no production, API, dependency, distribution, documentation, or user-visible impact. The focused test still passes on the latest PR head, and the relevant style/license checks succeeded.
### Evidence
- The GitHub file list and local triple-dot diff both contain exactly one changed file: `mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/StandaloneContextManagerBuilderTest.java`.
- The only code change is at `mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/StandaloneContextManagerBuilderTest.java:59`, where the private test helper `createModeConfiguration()` is changed from static to instance scope. The helper still constructs the same `ModeConfiguration`, and the test assertions are unchanged.
- There is no linked issue claim in the PR body, and no production/runtime path is touched.
- Local focused verification passed on PR head `16ab4abb98c03cbb646ac44335ebc08ffc1a8f86`: `StandaloneContextManagerBuilderTest` ran 2 tests with 0 failures and 0 errors.
- GitHub checks reviewed for this head showed `Check - Spotless`, `Check - CheckStyle`, and `Check - License` completed successfully.
### Review Details
- Reviewed Scope: latest PR head `16ab4abb98c03cbb646ac44335ebc08ffc1a8f86`, base `master` at `20a22adb7e77fe1a45afdda9ddf197d4bb0bd2a6`, local merge-base `20a22adb7e77fe1a45afdda9ddf197d4bb0bd2a6`; GitHub `/pulls/38917/files` matched the local triple-dot file list.
- Not Reviewed Scope: full repository CI, E2E, Proxy/native protocol behavior, distribution packaging, dependencies, and user documentation were not deeply reviewed because this PR changes only one private test helper.
- Verification:
- Review inventory script against the fetched PR refs: exit 0; scope matched GitHub.
- `./mvnw -pl mode/type/standalone/core -DskipITs -Dspotless.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -Dtest=org.apache.shardingsphere.mode.manager.standalone.StandaloneContextManagerBuilderTest -Dsurefire.failIfNoSpecifiedTests=false test`: exit 0; Tests run: 2, Failures: 0, Errors: 0, Skipped: 0.
- GitHub checks: `Check - Spotless`, `Check - CheckStyle`, and `Check - License` succeeded. The broader `CI` check was still in progress when inspected; I did not wait for it because the reviewed diff is test-only and the focused current-head sentinel plus relevant style checks passed. No required GitHub endpoint was inaccessible.
- Release Note / User Docs: not required; this is a private test-code style cleanup with no user-visible behavior or migration impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Code format for StandaloneContextManagerBuilderTest [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38917:
URL: https://github.com/apache/shardingsphere/pull/38917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org